Force a full page reload for top menu links#18136
Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom Feb 26, 2023
Merged
Force a full page reload for top menu links#18136MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
Conversation
MauricioFauth
force-pushed
the
top-menu-full-reload
branch
from
de82bfe to
f7cf631
Compare
Codecov ReportBase: 53.36% // Head: 53.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #18136 +/- ##
============================================
- Coverage 53.36% 53.33% -0.04%
Complexity 16428 16428
============================================
Files 629 629
Lines 67963 67963
============================================
- Hits 36268 36245 -23
- Misses 31695 31718 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Each page is a different page, so it makes more sense to do a full page reload instead of using AJAX to load the main content. This also avoid some possible issues with broken event handlers and not properly loaded pages. Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
MauricioFauth
force-pushed
the
top-menu-full-reload
branch
from
f7cf631 to
36a77f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each page is a different page, so it makes more sense to do a full page reload instead of using AJAX to load the main content.
This also avoid some possible issues with broken event handlers and not properly loaded pages.