Only allow resizing textarea vertically#18311
Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom Apr 8, 2023
Merged
Only allow resizing textarea vertically#18311MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #18311 +/- ##
============================================
+ Coverage 54.96% 54.98% +0.01%
Complexity 16399 16399
============================================
Files 628 628
Lines 64552 64552
============================================
+ Hits 35481 35493 +12
+ Misses 29071 29059 -12
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Maximilian Krög <[email protected]>
williamdes
approved these changes
Apr 7, 2023
MauricioFauth
approved these changes
Apr 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Textarea should not be resizable horizontally, that should be handled by the form layout.
To make it vertically resizable css is enough, no need for the jquery resizable call:
phpmyadmin/js/src/modules/functions.ts
Lines 261 to 268 in 10e6b24