Skip to content

Only allow resizing textarea vertically#18311

Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MoonE:textarea-resize
Apr 8, 2023
Merged

Only allow resizing textarea vertically#18311
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MoonE:textarea-resize

Conversation

@MoonE
Copy link
Copy Markdown
Contributor

@MoonE MoonE commented Apr 1, 2023

Textarea should not be resizable horizontally, that should be handled by the form layout.
To make it vertically resizable css is enough, no need for the jquery resizable call:

$(codemirrorEditor.getWrapperElement())
.css('resize', resizeType)
.resizable({
handles: handles,
resize: function () {
codemirrorEditor.setSize($(this).width(), $(this).height());
}
});

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (3f26fa5) 54.96% compared to head (d67b139) 54.98%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18311      +/-   ##
============================================
+ Coverage     54.96%   54.98%   +0.01%     
  Complexity    16399    16399              
============================================
  Files           628      628              
  Lines         64552    64552              
============================================
+ Hits          35481    35493      +12     
+ Misses        29071    29059      -12     
Flag Coverage Δ
dbase-extension 54.96% <ø> (ø)
recode-extension 54.93% <ø> (+<0.01%) ⬆️
unit-8.1-ubuntu-latest 54.92% <ø> (ø)
unit-8.2-ubuntu-latest 54.94% <ø> (+0.01%) ⬆️
unit-nightly-ubuntu-latest 54.92% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MoonE MoonE force-pushed the textarea-resize branch from 7c56629 to d67b139 Compare April 4, 2023 18:21
@williamdes williamdes requested a review from MauricioFauth April 7, 2023 08:44
@MauricioFauth MauricioFauth merged commit 35263b4 into phpmyadmin:master Apr 8, 2023
@MauricioFauth MauricioFauth self-assigned this Apr 8, 2023
@MoonE MoonE deleted the textarea-resize branch April 8, 2023 19:17
@williamdes williamdes added this to the 6.0.0 milestone Apr 9, 2023
@williamdes williamdes added the UI Issues relating to the user interface label Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UI Issues relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants