Skip to content

Remove support for the Recode extension#18547

Merged
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MauricioFauth:recode-removal
Jul 20, 2023
Merged

Remove support for the Recode extension#18547
MauricioFauth merged 1 commit intophpmyadmin:masterfrom
MauricioFauth:recode-removal

Conversation

@MauricioFauth
Copy link
Copy Markdown
Member

The Recode extension is not supported in PHP >= 7.4.

- https://www.php.net/manual/en/intro.recode.php
- https://www.php.net/manual/en/migration74.removed-extensions.php

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (d53d061) 56.49% compared to head (c245ab5) 56.48%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #18547      +/-   ##
============================================
- Coverage     56.49%   56.48%   -0.01%     
+ Complexity    16093    16091       -2     
============================================
  Files           638      638              
  Lines         63517    63509       -8     
============================================
- Hits          35882    35874       -8     
  Misses        27635    27635              
Flag Coverage Δ
dbase-extension 56.48% <100.00%> (-0.01%) ⬇️
recode-extension ?
unit-8.1-ubuntu-latest 56.45% <100.00%> (-0.01%) ⬇️
unit-8.2-ubuntu-latest 56.45% <100.00%> (-0.01%) ⬇️
unit-nightly-ubuntu-latest 56.41% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libraries/classes/Config/FormDisplay.php 23.60% <ø> (-1.34%) ⬇️
libraries/classes/Encoding.php 72.72% <ø> (-0.31%) ⬇️
libraries/classes/Config/ConfigFile.php 97.74% <100.00%> (ø)
libraries/classes/Config/Settings.php 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MauricioFauth MauricioFauth merged commit 35113db into phpmyadmin:master Jul 20, 2023
@MauricioFauth MauricioFauth deleted the recode-removal branch July 20, 2023 14:22
@MauricioFauth MauricioFauth self-assigned this Jul 20, 2023
@MauricioFauth MauricioFauth added this to the 6.0.0 milestone Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants