Skip to content

[Query Generator] support for BETWEEN and NOT BETWEEN#19352

Merged
williamdes merged 1 commit intophpmyadmin:masterfrom
faissaloux:query-generator-between
Jan 13, 2025
Merged

[Query Generator] support for BETWEEN and NOT BETWEEN#19352
williamdes merged 1 commit intophpmyadmin:masterfrom
faissaloux:query-generator-between

Conversation

@faissaloux
Copy link
Copy Markdown
Contributor

Hello 👋🏻

I have added support for BETWEEN and NOT BETWEEN for the Query Generator.

Current

Screenshot 2024-11-02 183108

After

Screenshot 2024-11-02 183233

It generates the needed inputs depending on the choosen op:

  • op that accepts multiple arguments (eg: IN / NOT IN): It allows to add multiple inputs.
  • op that accepts two arguments (eg: BETWEEN / NOT BETWEEN): It generates only the needed two inputs.
  • op that accepts one argument (eg: LIKE / NOT LIKE): It generates only the needed one input.
  • op that accepts no argument (eg: IS NULL / IS NOT NULL): it removes all inputs.
2024-11-02.18-45-49.mp4

@faissaloux faissaloux force-pushed the query-generator-between branch from 8b0ebbe to 02dec53 Compare November 2, 2024 17:58
Comment thread resources/js/src/database/multi_table_query.ts
Comment thread resources/js/src/database/multi_table_query.ts Outdated
Co-authored-by: William Desportes <williamdes@wdes.fr>
Signed-off-by: faissaloux <fwahabali@gmail.com>
@williamdes williamdes force-pushed the query-generator-between branch from 9145469 to 96fb3b3 Compare January 13, 2025 01:20
Copy link
Copy Markdown
Member

@williamdes williamdes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution !

@williamdes williamdes self-assigned this Jan 13, 2025
@williamdes williamdes added the Enhancement A feature request for improving phpMyAdmin label Jan 13, 2025
@williamdes williamdes added this to the 6.0.0 milestone Jan 13, 2025
williamdes added a commit that referenced this pull request Jan 13, 2025
Pull-request: #19352
Signed-off-by: William Desportes <williamdes@wdes.fr>
@williamdes williamdes merged commit 1bf55c4 into phpmyadmin:master Jan 13, 2025
@faissaloux faissaloux deleted the query-generator-between branch January 13, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement A feature request for improving phpMyAdmin

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants