Skip to content

Improvements to regnum2phyx.js#96

Merged
gaurav merged 8 commits intomasterfrom
reviewable-changes
Nov 11, 2025
Merged

Improvements to regnum2phyx.js#96
gaurav merged 8 commits intomasterfrom
reviewable-changes

Conversation

@gaurav
Copy link
Copy Markdown
Member

@gaurav gaurav commented Nov 10, 2025

These are the reviewable changes from PR #89, which are primarily regnum2phyx.js changes:

  • Improvements to how author names are rendered: we now support first-name first, last-name first, or last-name only.
  • Generate scientific name authorship by using first-name first and combining them with " and ".
  • Generate specifier authors by using last-name only and combining them with " and ".
  • Added a CLI option to configure the number of digits in the CLADO_ name, which now defaults to 7 instead of the previous 6.
  • Modified the script to produce CLADO_0000000 filenames instead of REGNUM_0000000 filenames.

Two other minor changes:

  • Added an optional test to ensure that Phyx files have at least one Newick phylogeny in order to see how many we have.
  • Removed phyloref_testcase.owl, which was previously a copy of the phyloref.owl ontology we used to do reasoning.

@gaurav gaurav force-pushed the reviewable-changes branch from 6349b71 to b2c028a Compare November 10, 2025 04:29
@gaurav gaurav changed the title Scripts bugfixes and miscellaneous changes Improvements to regnum2phyx.js Nov 10, 2025
@gaurav gaurav mentioned this pull request Nov 10, 2025
@gaurav gaurav marked this pull request as ready for review November 10, 2025 04:56
@gaurav gaurav requested a review from hlapp November 10, 2025 04:57
Copy link
Copy Markdown
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a number of Unexpected console statement warnings, if these aren't spurious and should eventually be eliminated, then it's perhaps worth to log this as an issue. (But doesn't seem worth holding up this PR, hence approving.)

Image

@gaurav
Copy link
Copy Markdown
Member Author

gaurav commented Nov 11, 2025

There are a number of Unexpected console statement warnings, if these aren't spurious and should eventually be eliminated, then it's perhaps worth to log this as an issue. (But doesn't seem worth holding up this PR, hence approving.)

I've added it as an issue: #97

@gaurav gaurav merged commit b5d9dc6 into master Nov 11, 2025
6 checks passed
@gaurav gaurav deleted the reviewable-changes branch November 11, 2025 22:12
gaurav added a commit that referenced this pull request Nov 11, 2025
This PR cleans up Regnum phylorefs in several ways:
* Renamed files from `REGNUM_*` to `CLADO_*` and increased the number of digits to seven.
* Moved Phylonym Phyx files and scripts out of the `encrypted/` directory so that they will no longer be encrypted (closes #82).
* Created subdirectories in `phyx/phylonym` for two kinds of errors we've been running into: `newick-problems` and `newick-recursion-error`.
* Added `phyx2owl.js`, a script to convert Phyx files to OWL for testing -- I'll replace this with the phyx.js library later.
* Added `phyxfix.js`, a script to correct errors in curated Phyx files on the fly, and used it to fix specifier authorities that were not loaded correctly (i.e. before PR #96).
* Incorporated some of the phylogenies prepared by Anna Becker.
* Removed two files with failing Newick strings and two test clade definitions from Regnum.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants