DDL through CreateDatabase or CreateTable gets wrong query

[wjhuang2016]

Please answer these questions before submitting your issue. Thanks!

1. What did you do?
   If possible, provide a recipe for reproducing the error.

We need to set the query for the DDL, like this

se.SetValue(sessionctx.QueryString, s.OriginText())

But we didn't set it, so query in DDL history is wrong.

4. What version of BR and TiDB/TiKV/PD are you using?

[kennytm]

@wjhuang2016 how will the query string be used, aside from presenting human-readable information? the "DDL" cannot be represented as an SQL string (e.g. you can't expose the alter-pk-ability in the CREATE TABLE statement), so using ConstructResultOfShowCreateTable would be misleading.

[wjhuang2016]

@wjhuang2016 how will the query string be used, aside from presenting human-readable information? the "DDL" cannot be represented as an SQL string (e.g. you can't expose the alter-pk-ability in the CREATE TABLE statement), so using ConstructResultOfShowCreateTable would be misleading.

Would you mean ConstructResultOfShowCreateTable do more than creating a table?

Besides，the query string is used by DM, it must be correct.

[kennytm]

DM should not replicate the BACKUP/RESTORE statements

[wjhuang2016]

DM should not replicate the BACKUP/RESTORE statements

I mean, the create table statement or create schema statement here.

[kennytm]

we should make DM filter them out as well

[wjhuang2016]

we should make DM filter them out as well

Sorry, it's not the DM goes wrong. It's the drainer. If we use BR from A to B, then use drainer from B to C. Since the DDL query is wrong, drainer will send to the wrong SQL to C.

[wjhuang2016]

@kennytm Any comment?

[kennytm]

Current consensus:

1. Binlog-drainer and CDC should be interrupted when receiving a BR restore action, because there is no way to tell the downstream where to download the SST files.
2. In order for Binlog/CDC to properly filter out the DDLs, they must still be in correct syntax.

[wjhuang2016]

Current consensus:

1. Binlog-drainer and CDC should be interrupted when receiving a BR restore action, because there is no way to tell the downstream where to download the SST files.
2. In order for Binlog/CDC to properly filter out the DDLs, they must still be in correct syntax.

According to the 2, we need to set the correct statement for these DDLs. Please fix it before the next release.

[kennytm]

Which? 4.0.3?