Conversation
Contributor
|
/lgtm |
Contributor
|
is there any plan to fix the tests? |
Collaborator
Author
Contributor
|
@lysu ok. but could you set the version to v1.4.1 instead of a git commit? |
Collaborator
Author
v1.4.0 also include go-sql-driver/mysql#676, we can use v1.3.0 |
Collaborator
Author
|
@kennytm PTAL, we have tried some way without modify parser but still have no good workaround for this.. |
Contributor
|
@lysu let's use 1.3.0. the dependency is only imported for an optional test. |
Collaborator
Author
|
yes, it's using 1.3.0 in the latest commit :) |
Contributor
|
/lgtm |
ti-srebot
approved these changes
Mar 17, 2021
tiancaiamao
pushed a commit
to tiancaiamao/parser
that referenced
this pull request
Apr 27, 2021
* downgrade mysql driver version * use v1.4.1 * use v1.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#851 introduce go-sql-driver/mysql dependence with high version for test case
but https://github.com/pingcap/mysql-tester will use pingcap/parser
and go-sql-driver/mysql#676 remove Warn API and strict mode which heavy used in pingcap/mysql-tester and pingcap/tidb-test.
(warn can workaround but strict need modify large number for tidb-test testcase)
so this PR choose downgrade mysql/driver version
What is changed and how it works?
downgrade veresion
Check List
Tests
Code changes
Side effects
Related changes
This change is