syncer.go: don't add row_id column to table info#422
Merged
WangXiangUSTC merged 2 commits intomasterfrom Dec 19, 2018
Merged
Conversation
this make it don't use _tidb_rowid column when dest-type = tidb
Contributor
|
LGTM |
Contributor
Author
|
@GregoryIan PTAL |
Contributor
Author
|
/run-all-tests |
Contributor
|
/run-all-tests |
WangXiangUSTC
pushed a commit
that referenced
this pull request
Dec 19, 2018
this make it don't use _tidb_rowid column when dest-type = tidb
WangXiangUSTC
pushed a commit
that referenced
this pull request
Dec 19, 2018
this make it don't use _tidb_rowid column when dest-type = tidb
WangXiangUSTC
pushed a commit
that referenced
this pull request
Dec 19, 2018
this make it don't use _tidb_rowid column when dest-type = tidb
WangXiangUSTC
added a commit
that referenced
this pull request
Dec 19, 2018
july2993
added a commit
that referenced
this pull request
Dec 25, 2018
this make it don't use _tidb_rowid column when dest-type = tidb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this make it don't use _tidb_rowid column when dest-type = tidb
What problem does this PR solve?
see https://internal.pingcap.net/jira/browse/TOOL-725
What is changed and how it works?
don't use _tidb_rowid column when dest-type = tidb
we can still remains tidb type.
and some feature for tidb type like:https://internal.pingcap.net/jira/browse/TOOL-727
although it don't work now actually...
Check List
Tests
create table and insert & delete
set dest-type = tidb, and run tests/binlog testcase
maybe better add a dest-type = tidb test case
Code changes
Side effects
Related changes
kafka