Skip to content

change test file to /tmp#443

Merged
zhouqiang-cl merged 1 commit intomasterfrom
zhouqiang-cl-patch-1
Jan 16, 2019
Merged

change test file to /tmp#443
zhouqiang-cl merged 1 commit intomasterfrom
zhouqiang-cl-patch-1

Conversation

@zhouqiang-cl
Copy link
Copy Markdown
Contributor

@zhouqiang-cl zhouqiang-cl commented Jan 16, 2019 •
edited by WangXiangUSTC
Loading

What problem does this PR solve?

use test file under /tmp, to avoid error syncer save CheckPointor info to file test err rename /tmp/test022073262 test: invalid cross-device link

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

@zhouqiang-cl
Copy link
Copy Markdown
Contributor Author

zhouqiang-cl commented Jan 16, 2019

/run-all-tests

@WangXiangUSTC
Copy link
Copy Markdown
Contributor

WangXiangUSTC commented Jan 16, 2019

LGTM

july2993
july2993 approved these changes Jan 16, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl zhouqiang-cl merged commit 2ea1ac0 into master Jan 16, 2019
@zhouqiang-cl zhouqiang-cl deleted the zhouqiang-cl-patch-1 branch January 16, 2019 05:14
WangXiangUSTC pushed a commit that referenced this pull request Jan 21, 2019
@zhouqiang-cl
change test file to /tmp (#443)
1437429
amyangfei
amyangfei reviewed Jan 21, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

IANTHEREAL pushed a commit that referenced this pull request Jan 21, 2019
@WangXiangUSTC @IANTHEREAL
change test file to /tmp (#443) (#448)
5eab5bb
mahjonp added a commit that referenced this pull request Apr 21, 2019
@mahjonp
change test file to /tmp (#443)
0b3b448
WangXiangUSTC pushed a commit that referenced this pull request Apr 23, 2019
@mahjonp @WangXiangUSTC
change test file to /tmp (#443) (#552)
5969213
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@amyangfei amyangfei amyangfei left review comments

@july2993 july2993 july2993 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

priority/normal status/LGT2 type/test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zhouqiang-cl @WangXiangUSTC @amyangfei @july2993
⚡