mysql.go: data may not consistent when no pk but has uk (#421)#446
Merged
WangXiangUSTC merged 2 commits intorelease-2.1from Jan 22, 2019
Merged
mysql.go: data may not consistent when no pk but has uk (#421)#446WangXiangUSTC merged 2 commits intorelease-2.1from
WangXiangUSTC merged 2 commits intorelease-2.1from
Conversation
* mysql.go: data may not consistent when no pk but has uk cause by drainer using uk as where to update (where a1 = * and a3 is NULL), may update the wrong row when any column is null, it will not be index, so we can't use it unless all column of index is not null
Contributor
Author
|
/run-all-tests |
Collaborator
|
fix CI, and it's better to let author pick self's PR |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cause by drainer using uk as where to update (where a1 = * and a3 is
NULL), may update the wrong row
when any column is null, it will not be index, so we can't use it unless
all column of index is not null
What problem does this PR solve?
fix a bug when no pk but has uk
What is changed and how it works?
git cherry-pick