expression: handle maketime unsigned hour overflow#10074
Merged
qw4990 merged 2 commits intopingcap:masterfrom Apr 9, 2019
Merged
expression: handle maketime unsigned hour overflow#10074qw4990 merged 2 commits intopingcap:masterfrom
qw4990 merged 2 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
@qw4990 PTAL |
Contributor
Author
|
/run-all-tests |
zz-jason
added
component/expression
contribution
Codecov Report
@@ Coverage Diff @@
## master #10074 +/- ##
================================================
- Coverage 78.0444% 78.0277% -0.0167%
================================================
Files 404 404
Lines 81970 81999 +29
================================================
+ Hits 63973 63982 +9
- Misses 13308 13320 +12
- Partials 4689 4697 +8 |
Contributor
|
/rebuild |
Contributor
|
@AndrewDi Thanks for your contribution, could you please cherry-pick this PR to branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #9735
What is changed and how it works?
Check List
Tests