types: extract month support 0#10116
Merged
zz-jason merged 3 commits intopingcap:masterfrom Apr 11, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10116 +/- ##
===========================================
Coverage ? 78.6088%
===========================================
Files ? 405
Lines ? 83885
Branches ? 0
===========================================
Hits ? 65941
Misses ? 13245
Partials ? 4699 |
Contributor
|
/run-all-tests |
30 tasks
Contributor
|
/rebuild |
qw4990
pushed a commit
to qw4990/tidb
that referenced
this pull request
Jun 4, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix extract month in issue #9728
select extract(MONTH FROM "0000-00-00") should return 0
What is changed and how it works?
remove some code, and add unit test
Check List
Tests
Related changes