Skip to content

planner: fix stack overflow caused by folding constant #10189

Merged
zz-jason merged 3 commits intopingcap:release-2.1from
qw4990:release-2.1_fix10156
Apr 18, 2019
Merged

planner: fix stack overflow caused by folding constant #10189
zz-jason merged 3 commits intopingcap:release-2.1from
qw4990:release-2.1_fix10156

Conversation

@qw4990
Copy link
Copy Markdown
Contributor

@qw4990 qw4990 commented Apr 18, 2019

cherry-pick for #10174.

@qw4990 qw4990 added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Apr 18, 2019
@qw4990 qw4990 requested review from alivxxx and zz-jason April 18, 2019 07:10
Copy link
Copy Markdown
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 18, 2019
winoros
winoros previously approved these changes Apr 18, 2019
Copy link
Copy Markdown
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Apr 18, 2019

/rebuild

@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Apr 18, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Apr 18, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990
Copy link
Copy Markdown
Contributor Author

qw4990 commented Apr 18, 2019

All checks have passed, PTAL~

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit 7bf69bd into pingcap:release-2.1 Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/planner SIG: Planner status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants