planner: fix wrong DATE/DATETIME comparison in BETWEEN function#10313
Merged
qw4990 merged 6 commits intopingcap:masterfrom May 6, 2019
Merged
planner: fix wrong DATE/DATETIME comparison in BETWEEN function#10313qw4990 merged 6 commits intopingcap:masterfrom
DATE/DATETIME comparison in BETWEEN function#10313qw4990 merged 6 commits intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10313 +/- ##
==============================================
+ Coverage 77.6699% 77.687% +0.017%
==============================================
Files 411 411
Lines 85441 85457 +16
==============================================
+ Hits 66362 66389 +27
+ Misses 14117 14112 -5
+ Partials 4962 4956 -6 |
Codecov Report
@@ Coverage Diff @@
## master #10313 +/- ##
================================================
+ Coverage 77.6576% 77.6648% +0.0071%
================================================
Files 411 411
Lines 85434 85466 +32
================================================
+ Hits 66346 66377 +31
+ Misses 14127 14125 -2
- Partials 4961 4964 +3 |
erjiaqing
changed the title
erjiaqing
changed the title
DATE/DATETIME comparison in BETWEEN function
qw4990
added
component/expression
type/bugfix
30 tasks
qw4990
reviewed
Apr 30, 2019
alivxxx
added
status/LGT2
Contributor
|
/run-all-tests |
zz-jason
pushed a commit
that referenced
this pull request
May 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9764
What is changed and how it works?
Add converts in
betweenToExpressionwhenGetCmpTp4MinMaxreturns DateTime type. The behavior should be same as MySQL 8.0 now.In mysql, If all values are string-like (string & datetime) and contains datetime, then values are converted to datetime.
Check List
Tests
Code changes