expression: fix issue that timestampadd is not compatible with Mysql#10314
Merged
ngaut merged 4 commits intopingcap:masterfrom May 5, 2019
Merged
expression: fix issue that timestampadd is not compatible with Mysql#10314ngaut merged 4 commits intopingcap:masterfrom
timestampadd is not compatible with Mysql#10314ngaut merged 4 commits intopingcap:masterfrom
Conversation
qw4990
added
type/compatibility
type/bugfix
30 tasks
Codecov Report
@@ Coverage Diff @@
## master #10314 +/- ##
================================================
+ Coverage 77.6622% 77.7023% +0.0401%
================================================
Files 411 411
Lines 85389 85435 +46
================================================
+ Hits 66315 66385 +70
+ Misses 14110 14094 -16
+ Partials 4964 4956 -8 |
Contributor
|
/rebuild |
Contributor
|
/run-all-tests tidb-test=pr/795 |
Contributor
Author
|
/rebuild |
zz-jason
added
status/LGT2
Member
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9730
What is changed and how it works?
Resolve date type according to input type and
unit.Check List
Tests