expression: addition between datetime and real interval is not compatible with Mysql#10347
Merged
qw4990 merged 1 commit intopingcap:masterfrom May 9, 2019
Merged
expression: addition between datetime and real interval is not compatible with Mysql#10347qw4990 merged 1 commit intopingcap:masterfrom
datetime and real interval is not compatible with Mysql#10347qw4990 merged 1 commit intopingcap:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10347 +/- ##
===============================================
- Coverage 77.6755% 77.6375% -0.038%
===============================================
Files 411 411
Lines 85440 85514 +74
===============================================
+ Hits 66366 66391 +25
- Misses 14113 14142 +29
- Partials 4961 4981 +20 |
Codecov Report
@@ Coverage Diff @@
## master #10347 +/- ##
================================================
- Coverage 77.3733% 77.3282% -0.0451%
================================================
Files 412 412
Lines 85722 85847 +125
================================================
+ Hits 66326 66384 +58
- Misses 14370 14412 +42
- Partials 5026 5051 +25 |
30 tasks
Contributor
|
/run-all-tests |
1 similar comment
Member
|
/run-all-tests |
Member
|
/rebuild |
1 similar comment
Contributor
|
/rebuild |
Contributor
Author
|
/run-all-tests |
qw4990
approved these changes
May 9, 2019
erjiaqing
added a commit
to erjiaqing/tidb
that referenced
this pull request
May 10, 2019
zz-jason
pushed a commit
that referenced
this pull request
May 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10346
What is changed and how it works?
Add
builtin{Add|Sub}Date{Datetime|String|Int}RealSigto support float type intervals.Check List
Tests