Skip to content

ddl: Speed up unit tests#10609

Merged
winkyao merged 6 commits intopingcap:masterfrom
zimulala:speedup-ut
May 31, 2019
Merged

ddl: Speed up unit tests#10609
winkyao merged 6 commits intopingcap:masterfrom
zimulala:speedup-ut

Conversation

@zimulala
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Speed up unit tests.
Before this PR:
ok github.com/pingcap/tidb/ddl 25.541s coverage: 81.1% of statements
After this PR:
ok github.com/pingcap/tidb/ddl 13.158s coverage: 81.0% of statements

What is changed and how it works?

  • Adjust the parallelism of the tests.

  • Adjust the value of SchemaOutOfDateRetryInterval to reduce the time to possibly retry.

Check List

Tests

  • Unit test

@codecov
Copy link
Copy Markdown

codecov bot commented May 27, 2019

Codecov Report

Merging #10609 into master will decrease coverage by 0.4048%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10609        +/-   ##
================================================
- Coverage   77.7107%   77.3059%   -0.4049%     
================================================
  Files           413        413                
  Lines         87504      87265       -239     
================================================
- Hits          68000      67461       -539     
- Misses        14356      14613       +257     
- Partials       5148       5191        +43

@codecov
Copy link
Copy Markdown

codecov bot commented May 27, 2019

Codecov Report

Merging #10609 into master will decrease coverage by 0.006%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10609        +/-   ##
================================================
- Coverage   78.2245%   78.2184%   -0.0061%     
================================================
  Files           413        413                
  Lines         87502      87542        +40     
================================================
+ Hits          68448      68474        +26     
- Misses        13927      13939        +12     
- Partials       5127       5129         +2

@zhouqiang-cl
Copy link
Copy Markdown
Contributor

/run-unit-test

@zhouqiang-cl
Copy link
Copy Markdown
Contributor

/run-unit-test

@zimulala
Copy link
Copy Markdown
Contributor Author

/run-all-tests

@zimulala
Copy link
Copy Markdown
Contributor Author

PTAL @winkyao @crazycs520 @bb7133

1 similar comment
@zimulala
Copy link
Copy Markdown
Contributor Author

PTAL @winkyao @crazycs520 @bb7133

Copy link
Copy Markdown
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label May 31, 2019
Comment thread ddl/db_integration_test.go Outdated
Comment thread ddl/ddl.go
@zimulala
Copy link
Copy Markdown
Contributor Author

PTAL @crazycs520 @bb7133

Copy link
Copy Markdown
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao merged commit 018f1d0 into pingcap:master May 31, 2019
@zimulala zimulala deleted the speedup-ut branch June 3, 2019 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/test status/LGT1 Indicates that a PR has LGTM 1.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants