Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10609 +/- ##
================================================
- Coverage 77.7107% 77.3059% -0.4049%
================================================
Files 413 413
Lines 87504 87265 -239
================================================
- Hits 68000 67461 -539
- Misses 14356 14613 +257
- Partials 5148 5191 +43 |
Codecov Report
@@ Coverage Diff @@
## master #10609 +/- ##
================================================
- Coverage 78.2245% 78.2184% -0.0061%
================================================
Files 413 413
Lines 87502 87542 +40
================================================
+ Hits 68448 68474 +26
- Misses 13927 13939 +12
- Partials 5127 5129 +2 |
Contributor
|
/run-unit-test |
Contributor
|
/run-unit-test |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
PTAL @winkyao @crazycs520 @bb7133 |
1 similar comment
Contributor
Author
|
PTAL @winkyao @crazycs520 @bb7133 |
bb7133
reviewed
May 31, 2019
Contributor
Author
|
PTAL @crazycs520 @bb7133 |
winkyao
approved these changes
May 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Speed up unit tests.
Before this PR:
ok github.com/pingcap/tidb/ddl 25.541s coverage: 81.1% of statementsAfter this PR:
ok github.com/pingcap/tidb/ddl 13.158s coverage: 81.0% of statementsWhat is changed and how it works?
Adjust the parallelism of the tests.
Adjust the value of
SchemaOutOfDateRetryIntervalto reduce the time to possibly retry.Check List
Tests