expression: fix issue that TimeIsNull is not compatible with MySQL #10753
Closed
qw4990 wants to merge 2 commits intopingcap:masterfrom
Closed
expression: fix issue that TimeIsNull is not compatible with MySQL #10753qw4990 wants to merge 2 commits intopingcap:masterfrom
TimeIsNull is not compatible with MySQL #10753qw4990 wants to merge 2 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
We have to merge pingcap/tipb#121 firstly to let |
winoros
reviewed
Jun 12, 2019
Member
There was a problem hiding this comment.
What's result of the following case:
The column can contains NULL.
But we filter NULL out at some places.
Like the SQL: select * from (select * from t where date_col is not null) t where date_col is null;
Why i mention this case is because that we'll maintain the NOT NULL during planning phase. Currently the flag is false when building the TIME IS NULL. It or another field will be true in the future.
30 tasks
Contributor
Author
|
Wait for #10790 and use it to solve this problem instead of introducing a new function signature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9763.
TimeIsNullin TiDB doesn't check if these DATETIME columns are declared as NOT NULL.But In MySQL:
This PR needs to be merged after pingcap/tipb#121.
For TiKV, since
TimeIsNullis not pushed down to TiKV, andtipbintikvtikv/tikv#4864) to lettipbcan't be upgraded in TiKV,we don't fix
TimeIsNullon TiKV.What is changed and how it works?
Check if these DATETIME columns are declared as NOT NULL.
Check List
Tests