Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10953 +/- ##
===========================================
Coverage 80.9319% 80.9319%
===========================================
Files 418 418
Lines 89275 89275
===========================================
Hits 72252 72252
Misses 11789 11789
Partials 5234 5234 |
Member
|
LGTM |
Contributor
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Since #10771, there will be a background goroutine to
Updateeven ifstats-leaseis 0, yet some tests are still under the assumption of no automatic updates. InTestConversion, the explicitUpdateand backgroundUpdatemay conflict each other, since their read and cache updates are two separate operations, so there may be the chances that the newer updates are overwritten by the older updates.This PR fixes it by disabling the background goroutine by set the
stats-leaseto negative.Also, there are still chances that the wrong result is caused by the failure of some stats operations, but there are no error checks for them, so this PR also checks the error for them.
Check List
Tests
Code changes
Side effects
Related changes