plan: fix the IsSelectForUpdateLockType check#21125
Merged
ti-srebot merged 3 commits intopingcap:masterfrom Nov 19, 2020
Merged
plan: fix the IsSelectForUpdateLockType check#21125ti-srebot merged 3 commits intopingcap:masterfrom
ti-srebot merged 3 commits intopingcap:masterfrom
Conversation
|
LGTM |
Contributor
|
@nullnotnil, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: planner(slack). |
Contributor
|
LGTM |
Contributor
Contributor
|
LGTM |
ti-srebot
added
status/LGT2
ti-srebot
approved these changes
Nov 19, 2020
Contributor
|
/merge |
Contributor
|
Your auto merge job has been accepted, waiting for:
|
ti-srebot
added
the
status/can-merge
Contributor
|
/run-all-tests |
Contributor
|
@cfzjywxk merge failed. |
Contributor
Author
|
/merge |
Contributor
|
Your auto merge job has been accepted, waiting for:
|
Contributor
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Fix #19336 on the master branch.
Problem Summary:
What is changed and how it works?
What's Changed:
Fix the check function and the possible compile error for
select .. lock in share.How it Works:
Related changes
Check List
Tests
Side effects
Release note