store/tikv: pipe the split and scatter task#23357
store/tikv: pipe the split and scatter task#23357nolouch wants to merge 3 commits intopingcap:masterfrom
Conversation
Signed-off-by: nolouch <nolouch@gmail.com>
|
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. DetailsReviewer can indicate their review by writing |
store/tikv/split_region.go
Outdated
| for _, r := range spResp.Regions { | ||
| tid := int64(0) | ||
| if tableID != nil { | ||
| tid = *tableID | ||
| } |
There was a problem hiding this comment.
| for _, r := range spResp.Regions { | |
| tid := int64(0) | |
| if tableID != nil { | |
| tid = *tableID | |
| } | |
| tid := int64(0) | |
| if tableID != nil { | |
| tid = *tableID | |
| } | |
| for _, r := range spResp.Regions { |
store/tikv/split_region.go
Outdated
| tid := int64(0) | ||
| if tableID != nil { | ||
| tid = *tableID | ||
| } |
There was a problem hiding this comment.
| tid := int64(0) | |
| if tableID != nil { | |
| tid = *tableID | |
| } |
Signed-off-by: nolouch <nolouch@gmail.com>
Signed-off-by: nolouch <nolouch@gmail.com>
| } | ||
| spResp := batchResp.resp.Resp.(*kvrpcpb.SplitRegionResponse) | ||
| for _, r := range spResp.Regions { | ||
| if err = s.scatterRegion(bo, r.Id, tableID); err == nil { |
There was a problem hiding this comment.
So it's still using
tidb/store/tikv/split_region.go
Line 217 in 579421f
There was a problem hiding this comment.
The current region scatter may not work in a specific case which described in tikv/pd#3422 , I think it's not related to the api.
|
@nolouch: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: nolouch nolouch@gmail.com
What problem does this PR solve?
close #22969
Problem Summary:

Splitting and Scattering at the same time will cause multiple conflicts on the same region.
What is changed and how it works?
pipeline all splits task and scatter tasks
Release note
split tablemore stable