Skip to content

metrics: support go-memstats-inuse and estimate-inuse (#43151)#46117

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-43151-to-release-6.1
Aug 15, 2023
Merged

metrics: support go-memstats-inuse and estimate-inuse (#43151)#46117
ti-chi-bot[bot] merged 3 commits intopingcap:release-6.1from
ti-chi-bot:cherry-pick-43151-to-release-6.1

Conversation

@ti-chi-bot
Copy link
Copy Markdown
Member

@ti-chi-bot ti-chi-bot commented Aug 15, 2023

This is an automated cherry-pick of #43151

What problem does this PR solve?

Issue Number: close #46120

Problem Summary:

What is changed and how it works?

image

the estimate-inuse is the old inuse which is calculated by gogc's formula.
go-memstat-inuse is from the go mem metrics.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

hawkingrei and others added 3 commits August 15, 2023 10:01
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Co-authored-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR. labels Aug 15, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Aug 15, 2023
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Aug 15, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, XuHuaiyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 15, 2023
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Aug 15, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-15 10:07:20.175807946 +0000 UTC m=+625604.724823918: ☑️ agreed by tangenta.
  • 2023-08-15 10:13:49.70100963 +0000 UTC m=+625994.250025617: ☑️ agreed by XuHuaiyu.

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 15, 2023
@ti-chi-bot ti-chi-bot bot merged commit c4b5de9 into pingcap:release-6.1 Aug 15, 2023
@ti-chi-bot ti-chi-bot deleted the cherry-pick-43151-to-release-6.1 branch April 15, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue. type/cherry-pick-for-release-6.1 This PR is cherry-picked to release-6.1 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants