statistics: use swiss table to improve fmsketch#47055
Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom Sep 20, 2023
Merged
statistics: use swiss table to improve fmsketch#47055ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
Conversation
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
do-not-merge/needs-tests-checked
release-note-none
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #47055 +/- ##
================================================
- Coverage 72.9684% 72.7710% -0.1975%
================================================
Files 1338 1359 +21
Lines 399152 406971 +7819
================================================
+ Hits 291255 296157 +4902
- Misses 89082 92091 +3009
+ Partials 18815 18723 -92
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
hawkingrei
force-pushed
the
use_fmsketch
branch
from
5c1fbf9 to
440ed4b
Compare
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
hawkingrei
force-pushed
the
use_fmsketch
branch
from
440ed4b to
4e7cddd
Compare
Member
Author
|
/unhold |
ti-chi-bot
bot
removed
the
do-not-merge/hold
ti-chi-bot
bot
added
needs-1-more-lgtm
qw4990
approved these changes
Sep 20, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hi-rustin, qw4990 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Member
Author
|
/retest |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #47057
Problem Summary:
What is changed and how it works?
fmsketch's hashmap is so big. it slows the copy speed and use many memory. we use swiss table to replace it.
Check List
Tests
before:
after:
more less usage of memory
before:
after:
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.