Skip to content

test: stabilize TestStalenessAndHistoryRead#65622

Merged
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
tangenta:fix-65621
Jan 20, 2026
Merged

test: stabilize TestStalenessAndHistoryRead#65622
ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
tangenta:fix-65621

Conversation

@tangenta
Copy link
Copy Markdown
Contributor

@tangenta tangenta commented Jan 17, 2026

What problem does this PR solve?

Issue Number: close #65621

Problem Summary:

Fix flaky TestStalenessAndHistoryRead by eliminating reliance on local wall-clock time when asserting snapshot schema versions.

What changed and how does it work?

  • Use PD TSO-driven timestamps (via @@tidb_current_ts and last commit TS) and wait for a TSO strictly after the DDL commit before asserting snapshot schema versions, removing clock-skew and same-millisecond races.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • Test-only change; not run locally (CI will cover).

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 17, 2026
@tangenta tangenta changed the title test: stabilize TestStalenessAndHistoryRead test: stabilize TestStalenessAndHistoryRead Jan 17, 2026
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 17, 2026
@tiprow
Copy link
Copy Markdown

tiprow bot commented Jan 17, 2026

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.7122%. Comparing base (88d21ed) to head (46a5376).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #65622        +/-   ##
================================================
- Coverage   77.8442%   77.7122%   -0.1320%     
================================================
  Files          1982       1913        -69     
  Lines        542465     532984      -9481     
================================================
- Hits         422278     414194      -8084     
- Misses       118528     118775       +247     
+ Partials       1659         15      -1644     
Flag Coverage Δ
integration 41.8218% <ø> (-6.3678%) ⬇️
unit 76.8342% <ø> (+0.3689%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 56.7974% <ø> (ø)
parser ∅ <ø> (∅)
br 48.7413% <ø> (-12.3989%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 19, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jan 19, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ekexium, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 19, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Jan 19, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-01-19 02:41:50.813004187 +0000 UTC m=+375338.426961043: ☑️ agreed by ekexium.
  • 2026-01-19 06:46:23.565724107 +0000 UTC m=+390011.179680953: ☑️ agreed by lance6716.

@tangenta
Copy link
Copy Markdown
Contributor Author

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Jan 19, 2026

@tangenta: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta
Copy link
Copy Markdown
Contributor Author

/retest

@tiprow
Copy link
Copy Markdown

tiprow bot commented Jan 20, 2026

@tangenta: PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test.

Details

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit e15515e into pingcap:master Jan 20, 2026
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unstable test TestStalenessAndHistoryRead

3 participants