test: stabilize TestStalenessAndHistoryRead#65622
test: stabilize TestStalenessAndHistoryRead#65622ti-chi-bot[bot] merged 1 commit intopingcap:masterfrom
TestStalenessAndHistoryRead#65622Conversation
TestStalenessAndHistoryRead
|
Hi @tangenta. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #65622 +/- ##
================================================
- Coverage 77.8442% 77.7122% -0.1320%
================================================
Files 1982 1913 -69
Lines 542465 532984 -9481
================================================
- Hits 422278 414194 -8084
- Misses 118528 118775 +247
+ Partials 1659 15 -1644
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ekexium, lance6716 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@tangenta: PRs from untrusted users cannot be marked as trusted with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@tangenta: PRs from untrusted users cannot be marked as trusted with DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What problem does this PR solve?
Issue Number: close #65621
Problem Summary:
Fix flaky
TestStalenessAndHistoryReadby eliminating reliance on local wall-clock time when asserting snapshot schema versions.What changed and how does it work?
@@tidb_current_tsand last commit TS) and wait for a TSO strictly after the DDL commit before asserting snapshot schema versions, removing clock-skew and same-millisecond races.Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.