meta, planner: add the `UnsignedFlag` to the type of `_tidb_commit_ts` by time-and-fate · Pull Request #66656 · pingcap/tidb

time-and-fate · 2026-03-03T09:03:35Z

What problem does this PR solve?

Issue Number: ref #64281

What changed and how does it work?

As the title says.

Check List

Tests

Unit test
Integration test
Manual test (add detailed scripts or steps below)
No need to test
- I checked and no code files have been changed.

Side effects

Performance regression: Consumes more CPU
Performance regression: Consumes more Memory
Breaking backward compatibility

Documentation

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

Summary by CodeRabbit

Chores
- Marked an internal timestamp column as unsigned to improve compatibility and consistency when handling numeric values. This ensures the column is treated as a non-negative integer across schemas and validations, reducing potential mismatches when reading, validating, or comparing stored timestamps.

pantheon-ai · 2026-03-03T09:03:41Z

Review Complete

Findings: 1 issues
Posted: 0
Duplicates/Skipped: 1

_{ℹ️ Learn more details on Pantheon AI.}

coderabbitai · 2026-03-03T09:04:30Z

📝 Walkthrough

Walkthrough

Added the mysql.UnsignedFlag to the ExtraCommitTS column's flags in two places (meta model and planner type), changing the column to unsigned without other behavioral or control-flow changes.

Changes

Cohort / File(s)	Summary
Meta column update `pkg/meta/model/column.go`	In `NewExtraCommitTSColInfo`, set `colInfo` flags to include `mysql.UnsignedFlag` via bitwise OR; no other attributes changed.
Planner type update `pkg/planner/core/operator/logicalop/logical_datasource.go`	Marked the ExtraCommitTS schema column's return type as unsigned by OR-ing `mysql.UnsignedFlag` onto the longlong `RetType`; no control-flow changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nudged a flag, a quiet tweak,
A tiny hop — the types now speak,
Unsigned and neat, the timestamp gleams,
Small change, soft thump, and happy dreams.

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	The description is incomplete. It lacks a problem summary, detailed explanation of what changed, and adequate context. The 'What changed and how does it work?' section only states 'As the title says.' without elaboration.	Expand the 'Problem Summary' and 'What changed and how does it work?' sections with specific details about why UnsignedFlag is needed and how the changes address the issue.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Title check	✅ Passed	The title accurately describes the main change: adding the UnsignedFlag to the _tidb_commit_ts column type across two files (meta and planner modules).

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

pkg/meta/model/column.go (1)
378-392: ⚠️ Potential issue | 🟠 Major

Add unit test for NewExtraCommitTSColInfo() in column_test.go following the existing pattern.

This new metadata column constructor needs test coverage. Add a test similar to the existing one for NewExtraPhysTblIDColInfo() at line 103-104 of pkg/meta/model/column_test.go to verify the ColumnInfo is initialized correctly with the expected type and flags (TypeLonglong + UnsignedFlag).
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@pkg/meta/model/column.go` around lines 378 - 392, Add a unit test in
pkg/meta/model/column_test.go mirroring the existing test for
NewExtraPhysTblIDColInfo: call NewExtraCommitTSColInfo(), assert the returned
*ColumnInfo has ID == ExtraCommitTSID and Name == ExtraCommitTSName, and verify
its type and flags are set to mysql.TypeLonglong with mysql.UnsignedFlag (also
check flen/decimal/charset/collate if following the same assertions pattern used
by the NewExtraPhysTblIDColInfo test). Use the same test structure and helper
assertions as the existing test for NewExtraPhysTblIDColInfo to ensure
consistent coverage.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Outside diff comments:
In `@pkg/meta/model/column.go`:
- Around line 378-392: Add a unit test in pkg/meta/model/column_test.go
mirroring the existing test for NewExtraPhysTblIDColInfo: call
NewExtraCommitTSColInfo(), assert the returned *ColumnInfo has ID ==
ExtraCommitTSID and Name == ExtraCommitTSName, and verify its type and flags are
set to mysql.TypeLonglong with mysql.UnsignedFlag (also check
flen/decimal/charset/collate if following the same assertions pattern used by
the NewExtraPhysTblIDColInfo test). Use the same test structure and helper
assertions as the existing test for NewExtraPhysTblIDColInfo to ensure
consistent coverage.

ℹ️ Review info

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 21b5bb6 and 4361094.

📒 Files selected for processing (1)

pkg/meta/model/column.go

time-and-fate · 2026-03-03T09:55:25Z

/retest

pkg/meta/model/column.go

lcwangchao

rest LGTM

Co-authored-by: Chao Wang <cclcwangchao@hotmail.com>

pantheon-ai · 2026-03-03T10:00:24Z

Review Complete

Findings: 1 issues
Posted: 0
Duplicates/Skipped: 1

_{ℹ️ Learn more details on Pantheon AI.}

ti-chi-bot · 2026-03-03T10:04:29Z

[LGTM Timeline notifier]

Timeline:

2026-03-03 09:57:56.254967382 +0000 UTC m=+265720.833046576: ☑️ agreed by xhebox.
2026-03-03 10:04:27.688001905 +0000 UTC m=+266112.266081089: ☑️ agreed by lcwangchao.

codecov · 2026-03-03T10:24:03Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.5729%. Comparing base (21b5bb6) to head (82c3962).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files

@@               Coverage Diff                @@
##             master     #66656        +/-   ##
================================================
- Coverage   77.6714%   77.5729%   -0.0986%     
================================================
  Files          2008       1929        -79     
  Lines        549230     537917     -11313     
================================================
- Hits         426595     417278      -9317     
+ Misses       120964     120621       -343     
+ Partials       1671         18      -1653

Flag	Coverage Δ
integration	`41.3530% <100.0000%> (-6.8401%)`	⬇️
unit	`76.6465% <100.0000%> (+0.3286%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	`56.7974% <ø> (ø)`
parser	`∅ <ø> (∅)`
br	`48.8331% <ø> (-12.0523%)`	⬇️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

time-and-fate · 2026-03-03T10:36:33Z

/retest

time-and-fate · 2026-03-03T11:51:11Z

/retest

lcwangchao · 2026-03-03T12:17:29Z

/hold

pantheon-ai · 2026-03-03T13:23:00Z

Review Complete

Findings: 0 issues
Posted: 0
Duplicates/Skipped: 0

_{ℹ️ Learn more details on Pantheon AI.}

ti-chi-bot · 2026-03-03T13:37:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lcwangchao, winoros, wjhuang2016, xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/meta/OWNERS~~ [wjhuang2016]
~~pkg/planner/OWNERS~~ [winoros]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pantheon-ai

✅ Code looks good. No issues found.

lcwangchao · 2026-03-03T15:37:34Z

/unhold

lcwangchao · 2026-03-03T15:37:49Z

/retest

add

4361094

ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 3, 2026

ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2026

coderabbitai bot reviewed Mar 3, 2026

View reviewed changes

xhebox approved these changes Mar 3, 2026

View reviewed changes

ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 3, 2026

lcwangchao reviewed Mar 3, 2026

View reviewed changes

pkg/meta/model/column.go Outdated Show resolved Hide resolved

lcwangchao reviewed Mar 3, 2026

View reviewed changes

Apply suggestion from @lcwangchao

5279302

Co-authored-by: Chao Wang <cclcwangchao@hotmail.com>

lcwangchao approved these changes Mar 3, 2026

View reviewed changes

ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 3, 2026

ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026

address comments

82c3962

ti-chi-bot bot added the sig/planner SIG: Planner label Mar 3, 2026

winoros approved these changes Mar 3, 2026

View reviewed changes

time-and-fate changed the title ~~meta: add the UnsignedFlag to the type of _tidb_commit_ts~~ meta, planner: add the UnsignedFlag to the type of _tidb_commit_ts Mar 3, 2026

wjhuang2016 approved these changes Mar 3, 2026

View reviewed changes

ti-chi-bot bot added the approved label Mar 3, 2026

pantheon-ai bot reviewed Mar 3, 2026

View reviewed changes

ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026

ti-chi-bot bot merged commit 0b23ce6 into pingcap:master Mar 3, 2026
32 checks passed

xzhangxian1008 mentioned this pull request Mar 9, 2026

meta, planner: add the UnsignedFlag to the type of _tidb_commit_ts #66794

Closed

13 tasks

time-and-fate added a commit to time-and-fate/tidb that referenced this pull request Mar 12, 2026

include pingcap#66656

6f36fa6

coderabbitai bot mentioned this pull request Mar 13, 2026

br, meta, table: backport active-active related fixes | tidb-test=release-8.5-20260121-v8.5.5 #66986

Closed

13 tasks

Conversation

time-and-fate commented Mar 3, 2026 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

What changed and how does it work?

Check List

Release note

Summary by CodeRabbit

Uh oh!

pantheon-ai bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

time-and-fate commented Mar 3, 2026

Uh oh!

Uh oh!

lcwangchao left a comment

Choose a reason for hiding this comment

Uh oh!

pantheon-ai bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ti-chi-bot bot commented Mar 3, 2026

[LGTM Timeline notifier]

Uh oh!

codecov bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

time-and-fate commented Mar 3, 2026

Uh oh!

time-and-fate commented Mar 3, 2026

Uh oh!

lcwangchao commented Mar 3, 2026

Uh oh!

pantheon-ai bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ti-chi-bot bot commented Mar 3, 2026

Uh oh!

pantheon-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

lcwangchao commented Mar 3, 2026

Uh oh!

lcwangchao commented Mar 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

time-and-fate commented Mar 3, 2026 •

edited by coderabbitai bot

Loading

pantheon-ai bot commented Mar 3, 2026 •

edited

Loading

coderabbitai bot commented Mar 3, 2026 •

edited

Loading

pantheon-ai bot commented Mar 3, 2026 •

edited

Loading

codecov bot commented Mar 3, 2026 •

edited

Loading

pantheon-ai bot commented Mar 3, 2026 •

edited

Loading