Skip to content

*: exclude make bazel_lint_changed from default AGENTS local flow#66678

Merged
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
D3Hunter:codex/remove-bazellint-requirement
Mar 5, 2026
Merged

*: exclude make bazel_lint_changed from default AGENTS local flow#66678
ti-chi-bot[bot] merged 3 commits intopingcap:masterfrom
D3Hunter:codex/remove-bazellint-requirement

Conversation

@D3Hunter
Copy link
Copy Markdown
Contributor

@D3Hunter D3Hunter commented Mar 4, 2026

What problem does this PR solve?

Issue Number: ref #63847

Problem Summary:

make bazel_lint_changed can be slow and resource-intensive on local macOS development machines. The default local workflow guidance in AGENTS.md should avoid requiring it for normal local development.

What changed and how does it work?

In AGENTS.md Build Flow:

  • Removed make bazel_lint_changed from the "Recommended local build flow" command block.
  • Added explicit policy text that make bazel_lint_changed is intentionally excluded from the default local flow and agents MUST NOT run it unless explicitly requested by the user.

This keeps the guidance clear and prevents unnecessary heavy local lint runs.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

Summary by CodeRabbit

  • Documentation
    • Development workflow documentation has been comprehensively updated to clarify build process procedures and lint command requirements. The default lint command specification has been revised to streamline standard development workflows. Explicit guidance has been provided regarding command execution requirements, usage constraints, and specific scenarios where alternative lint procedures should be applied.

…not necessary to be run on any code change, and makes normal coding slow
@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 4, 2026
@pantheon-ai
Copy link
Copy Markdown

pantheon-ai bot commented Mar 4, 2026

Review Failed

Environment preparation failed after 3 attempts due to infrastructure unavailability (upstream provider overload). The review could not be completed. Please retry later.

ℹ️ Learn more details on Pantheon AI.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 4, 2026
@tiprow
Copy link
Copy Markdown

tiprow bot commented Mar 4, 2026

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 4, 2026

📝 Walkthrough

Walkthrough

Updated AGENTS.md: the "Before finishing" guidance now uses make lint instead of make bazel_lint_changed, and a note was added that make bazel_lint_changed is excluded from the local flow and MUST NOT be run unless explicitly requested. No code, control flow, or public signatures changed.

Changes

Cohort / File(s) Summary
Documentation
AGENTS.md
Replaced pre-finish lint command reference: make bazel_lint_changedmake lint. Added explicit note that make bazel_lint_changed is excluded and MUST NOT be run locally. Lines changed: +3/-2.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐇 I hopped through a doc, made the wording light,
swapped a long command for one that's polite.
A tiny hop, a tidy fix, the notes now hint—
"Use make lint," said the rabbit, "not bazel_lint_changed." 🥕

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: excluding 'make bazel_lint_changed' from the default AGENTS local flow, which aligns with the file modifications in AGENTS.md.
Description check ✅ Passed The description includes all key required sections: issue reference, problem summary, what changed and how it works, checklist with appropriate selections, and release note.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pantheon-ai
Copy link
Copy Markdown

pantheon-ai bot commented Mar 4, 2026

Review Failed

Environment preparation failed after 3 attempts due to infrastructure unavailability (upstream provider overload). The review could not be completed. Please retry later.

ℹ️ Learn more details on Pantheon AI.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
AGENTS.md (1)

31-31: ⚠️ Potential issue | 🟡 Minor

Fix markdown table row pipe style (missing leading |).

Line 31 uses trailing-only pipe style and triggers MD055; add a leading pipe to keep table formatting/lint clean.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@AGENTS.md` at line 31, The table row "Before finishing | MUST run `make lint`
if there are code changes. SHOULD self-review diff quality before finishing. |"
uses trailing-only pipe style and triggers MD055; update that row to use
leading-and-trailing pipe style by adding a leading '|' so it becomes a standard
Markdown table row, ensuring the linter no longer flags MD055.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@AGENTS.md`:
- Line 31: The table row "Before finishing | MUST run `make lint` if there are
code changes. SHOULD self-review diff quality before finishing. |" uses
trailing-only pipe style and triggers MD055; update that row to use
leading-and-trailing pipe style by adding a leading '|' so it becomes a standard
Markdown table row, ensuring the linter no longer flags MD055.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: efc36935-20a2-4a73-b477-86621b1136ca

📥 Commits

Reviewing files that changed from the base of the PR and between 78dde66 and 7453bc7.

📒 Files selected for processing (1)
  • AGENTS.md

@D3Hunter D3Hunter changed the title *: remove mandatory make bazel_lint_changed requirement from AGENTS.md *: switch AGENTS.md pre-finish check from make bazel_lint_changed to make lint Mar 4, 2026
@D3Hunter D3Hunter changed the title *: switch AGENTS.md pre-finish check from make bazel_lint_changed to make lint *: use make lint in AGENTS.md for faster, lower-resource local checks Mar 4, 2026
@pantheon-ai
Copy link
Copy Markdown

pantheon-ai bot commented Mar 4, 2026

Review Failed

Environment preparation failed after 3 attempts due to infrastructure unavailability (upstream provider overload). The review could not be completed. Please retry later.

ℹ️ Learn more details on Pantheon AI.

@D3Hunter D3Hunter changed the title *: use make lint in AGENTS.md for faster, lower-resource local checks *: exclude make bazel_lint_changed from default AGENTS local flow Mar 4, 2026
Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♻️ Duplicate comments (1)
AGENTS.md (1)

31-31: ⚠️ Potential issue | 🟡 Minor

Fix markdown table pipe style on this row.

This row is missing the leading |, which triggers markdownlint MD055 and can break table rendering consistency.

Proposed minimal fix
- Before finishing | MUST run `make lint` if there are code changes. SHOULD self-review diff quality before finishing. |
+| Before finishing | MUST run `make lint` if there are code changes. SHOULD self-review diff quality before finishing. |

As per coding guidelines: "AGENTS.md: Document agent responsibilities, capabilities, and interactions in AGENTS.md".

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@AGENTS.md` at line 31, The markdown table row "Before finishing | MUST run
`make lint` if there are code changes. SHOULD self-review diff quality before
finishing. |" is missing the leading pipe which triggers MD055 and breaks table
rendering; fix it by adding a leading '|' at the start of that row so it reads
"| Before finishing | MUST run `make lint` if there are code changes. SHOULD
self-review diff quality before finishing. |" ensuring consistent pipe-style
table formatting in AGENTS.md.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@AGENTS.md`:
- Line 31: The markdown table row "Before finishing | MUST run `make lint` if
there are code changes. SHOULD self-review diff quality before finishing. |" is
missing the leading pipe which triggers MD055 and breaks table rendering; fix it
by adding a leading '|' at the start of that row so it reads "| Before finishing
| MUST run `make lint` if there are code changes. SHOULD self-review diff
quality before finishing. |" ensuring consistent pipe-style table formatting in
AGENTS.md.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: f8173ffa-165a-4184-b9d3-7bde6ed2c772

📥 Commits

Reviewing files that changed from the base of the PR and between 7453bc7 and ee110ad.

📒 Files selected for processing (1)
  • AGENTS.md

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 4, 2026
@D3Hunter
Copy link
Copy Markdown
Contributor Author

D3Hunter commented Mar 5, 2026

@lance6716

@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 5, 2026
@ti-chi-bot
Copy link
Copy Markdown

ti-chi-bot bot commented Mar 5, 2026

[LGTM Timeline notifier]

Timeline:

  • 2026-03-04 12:59:41.994828204 +0000 UTC m=+363026.572907398: ☑️ agreed by winoros.
  • 2026-03-05 02:25:28.88288682 +0000 UTC m=+411373.460966014: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit 6d48228 into pingcap:master Mar 5, 2026
7 of 8 checks passed
@D3Hunter D3Hunter deleted the codex/remove-bazellint-requirement branch March 5, 2026 02:50
@hawkingrei
Copy link
Copy Markdown
Member

The core issue here is that bazel_lint_changed doesn't have remote cache enabled, causing it to always compile from scratch locally, which slows down the experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants