*: exclude make bazel_lint_changed from default AGENTS local flow#66678
Conversation
…not necessary to be run on any code change, and makes normal coding slow
|
Review Failed Environment preparation failed after 3 attempts due to infrastructure unavailability (upstream provider overload). The review could not be completed. Please retry later. ℹ️ Learn more details on Pantheon AI. |
|
Hi @D3Hunter. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review Failed Environment preparation failed after 3 attempts due to infrastructure unavailability (upstream provider overload). The review could not be completed. Please retry later. ℹ️ Learn more details on Pantheon AI. |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
AGENTS.md (1)
31-31:⚠️ Potential issue | 🟡 MinorFix markdown table row pipe style (missing leading
|).Line 31 uses trailing-only pipe style and triggers MD055; add a leading pipe to keep table formatting/lint clean.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@AGENTS.md` at line 31, The table row "Before finishing | MUST run `make lint` if there are code changes. SHOULD self-review diff quality before finishing. |" uses trailing-only pipe style and triggers MD055; update that row to use leading-and-trailing pipe style by adding a leading '|' so it becomes a standard Markdown table row, ensuring the linter no longer flags MD055.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@AGENTS.md`:
- Line 31: The table row "Before finishing | MUST run `make lint` if there are
code changes. SHOULD self-review diff quality before finishing. |" uses
trailing-only pipe style and triggers MD055; update that row to use
leading-and-trailing pipe style by adding a leading '|' so it becomes a standard
Markdown table row, ensuring the linter no longer flags MD055.
|
Review Failed Environment preparation failed after 3 attempts due to infrastructure unavailability (upstream provider overload). The review could not be completed. Please retry later. ℹ️ Learn more details on Pantheon AI. |
There was a problem hiding this comment.
♻️ Duplicate comments (1)
AGENTS.md (1)
31-31:⚠️ Potential issue | 🟡 MinorFix markdown table pipe style on this row.
This row is missing the leading
|, which triggers markdownlint MD055 and can break table rendering consistency.Proposed minimal fix
- Before finishing | MUST run `make lint` if there are code changes. SHOULD self-review diff quality before finishing. | +| Before finishing | MUST run `make lint` if there are code changes. SHOULD self-review diff quality before finishing. |As per coding guidelines: "AGENTS.md: Document agent responsibilities, capabilities, and interactions in AGENTS.md".
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@AGENTS.md` at line 31, The markdown table row "Before finishing | MUST run `make lint` if there are code changes. SHOULD self-review diff quality before finishing. |" is missing the leading pipe which triggers MD055 and breaks table rendering; fix it by adding a leading '|' at the start of that row so it reads "| Before finishing | MUST run `make lint` if there are code changes. SHOULD self-review diff quality before finishing. |" ensuring consistent pipe-style table formatting in AGENTS.md.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@AGENTS.md`:
- Line 31: The markdown table row "Before finishing | MUST run `make lint` if
there are code changes. SHOULD self-review diff quality before finishing. |" is
missing the leading pipe which triggers MD055 and breaks table rendering; fix it
by adding a leading '|' at the start of that row so it reads "| Before finishing
| MUST run `make lint` if there are code changes. SHOULD self-review diff
quality before finishing. |" ensuring consistent pipe-style table formatting in
AGENTS.md.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lance6716, winoros The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The core issue here is that bazel_lint_changed doesn't have remote cache enabled, causing it to always compile from scratch locally, which slows down the experience. |
What problem does this PR solve?
Issue Number: ref #63847
Problem Summary:
make bazel_lint_changedcan be slow and resource-intensive on local macOS development machines. The default local workflow guidance inAGENTS.mdshould avoid requiring it for normal local development.What changed and how does it work?
In
AGENTS.mdBuild Flow:make bazel_lint_changedfrom the "Recommended local build flow" command block.make bazel_lint_changedis intentionally excluded from the default local flow and agents MUST NOT run it unless explicitly requested by the user.This keeps the guidance clear and prevents unnecessary heavy local lint runs.
Check List
Tests
Side effects
Documentation
Release note
Summary by CodeRabbit