Skip to content

executor: remove some useless code and avoid some redundancy check (cherry-pick)#7881

Merged
ngaut merged 1 commit intopingcap:release-2.1from
jackysp:insert_refactor
Oct 15, 2018
Merged

executor: remove some useless code and avoid some redundancy check (cherry-pick)#7881
ngaut merged 1 commit intopingcap:release-2.1from
jackysp:insert_refactor

Conversation

@jackysp
Copy link
Copy Markdown
Contributor

@jackysp jackysp commented Oct 12, 2018

What problem does this PR solve?

Cherry-pick #7639 to release 2.1.

What is changed and how it works?

Cherry-pick to the new release.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

PTAL @winkyao @lysu

@jackysp jackysp added type/bugfix This PR fixes a bug. sig/execution SIG execution type/2.1 cherry-pick labels Oct 12, 2018
@jackysp
Copy link
Copy Markdown
Contributor Author

jackysp commented Oct 12, 2018

/run-all-tests

@zz-jason
Copy link
Copy Markdown
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 15, 2018
Copy link
Copy Markdown
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 15, 2018
@ngaut ngaut merged commit a84cce1 into pingcap:release-2.1 Oct 15, 2018
@jackysp jackysp deleted the insert_refactor branch October 15, 2018 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants