ddl: fix cancel drop index error#8504
Merged
crazycs520 merged 15 commits intopingcap:masterfrom Dec 7, 2018
Merged
Conversation
Contributor
Author
|
/run-all-tests |
Contributor
Author
Contributor
|
@crazycs520 Please add proper label. |
Contributor
Author
|
/run-all-tests |
ciscoxll
reviewed
Nov 29, 2018
winkyao
reviewed
Nov 29, 2018
winkyao
reviewed
Nov 30, 2018
ciscoxll
reviewed
Nov 30, 2018
ciscoxll
reviewed
Nov 30, 2018
winkyao
reviewed
Nov 30, 2018
Contributor
Author
|
/run-all-tests |
zimulala
reviewed
Dec 3, 2018
zimulala
reviewed
Dec 3, 2018
Contributor
Author
|
/run-all-tests |
ciscoxll
added
status/LGT2
zimulala
reviewed
Dec 5, 2018
crazycs520
force-pushed
the
fix-cancel
branch
from
6027b18 to
fd9864d
Compare
Contributor
|
@zimulala PTAL |
ciscoxll
reviewed
Dec 7, 2018
Contributor
ciscoxll
left a comment
ciscoxll
left a comment
There was a problem hiding this comment.
@crazycs520 Please solve the CI error.
Contributor
Author
|
/run-all-tests |
winkyao
approved these changes
Dec 7, 2018
crazycs520
added
status/LGT3
iamzhoug37
pushed a commit
to iamzhoug37/tidb
that referenced
this pull request
Dec 13, 2018
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Feb 27, 2019
zz-jason
pushed a commit
that referenced
this pull request
Feb 27, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Feb 27, 2019
zimulala
pushed a commit
that referenced
this pull request
Feb 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
releate PR #8171
This PR make cancel drop index work correctly. Old tidb version cancel drop index may cause the index states neither on
StatePublicnorStateNone. For client, the index is not visible, but client add index with the same name will fail because the name of 'xxx' index is already exists.What is changed and how it works?
We can only cancel drop index job when the index state is on
StatePublicorStateWriteOnly, otherwise, cancel index and make the index state rollback to public may cause data consistency.Check List
Tests
Code changes
Side effects
Related changes
This change is