Skip to content

sessionctx/variable: fix panic when set variable='' (#9533)#9539

Merged
shenli merged 2 commits intopingcap:release-2.1from
crazycs520:fix-set-panic-2.1
Mar 4, 2019
Merged

sessionctx/variable: fix panic when set variable='' (#9533)#9539
shenli merged 2 commits intopingcap:release-2.1from
crazycs520:fix-set-panic-2.1

Conversation

@crazycs520
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

cherry-pick #9533

What is changed and how it works?

Check List

@crazycs520
Copy link
Copy Markdown
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

@crazycs520
Copy link
Copy Markdown
Contributor Author

/run-all-tests tidb-test=release-2.1 tidb-private-test=release-2.1 tikv=release-2.1

Copy link
Copy Markdown
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from eurekaka March 4, 2019 12:37
@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2019
Copy link
Copy Markdown
Member

@shenli shenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shenli shenli added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 4, 2019
@shenli shenli merged commit 3d40d25 into pingcap:release-2.1 Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants