expression: fix week func format#9685
Merged
imtbkcat merged 11 commits intopingcap:masterfrom Mar 13, 2019
Merged
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #9685 +/- ##
===============================================
- Coverage 67.375% 67.3728% -0.0022%
===============================================
Files 377 377
Lines 79384 79391 +7
===============================================
+ Hits 53485 53488 +3
- Misses 21123 21125 +2
- Partials 4776 4778 +2 |
xiekeyi98
reviewed
Mar 13, 2019
Contributor
xiekeyi98
left a comment
xiekeyi98
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
Would you mind adding some unit tests to catch this issue?
Contributor
Author
|
@xiekeyi98 Already added. |
Contributor
|
/run-all-tests |
xiekeyi98
changed the title
xiekeyi98
added
status/LGT1
imtbkcat
reviewed
Mar 13, 2019
…ix-week-format-issure
Contributor
Author
|
@imtbkcat PTAL. |
|
/run-all-tests |
Contributor
|
@zyycj Thanks for your contribution. |
glock42
added a commit
to glock42/tidb
that referenced
this pull request
Mar 15, 2019
30 tasks
zz-jason
pushed a commit
that referenced
this pull request
Mar 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the problem that the variable
default_week_formatdoesn't work.fix #9669
What is changed and how it works?
Use the SystemVar
DefaultWeekFormatto invoke theWeekfunction.Check List
Tests