types: fix incompatible issue for builtin function str_to_date#9693
Merged
zz-jason merged 3 commits intopingcap:masterfrom Mar 14, 2019
Merged
types: fix incompatible issue for builtin function str_to_date#9693zz-jason merged 3 commits intopingcap:masterfrom
str_to_date#9693zz-jason merged 3 commits intopingcap:masterfrom
Conversation
qw4990
added
type/compatibility
type/bugfix
qw4990
requested review from
alivxxx,
eurekaka,
tiancaiamao,
winoros and
zz-jason
qw4990
changed the title
StrToDate is incompatible with MysqlStrToDate is incompatible with Mysql
Codecov Report
@@ Coverage Diff @@
## master #9693 +/- ##
===============================================
- Coverage 67.398% 67.3904% -0.0077%
===============================================
Files 377 377
Lines 79434 79443 +9
===============================================
Hits 53537 53537
- Misses 21117 21123 +6
- Partials 4780 4783 +3 |
zz-jason
added
status/LGT2
zz-jason
changed the title
StrToDate is incompatible with Mysqlstr_to_date
30 tasks
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Mar 20, 2019
zz-jason
pushed a commit
that referenced
this pull request
Mar 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9666
What is changed and how it works?
Fix incompatible problems on specifier
%H,%I,%i,%s,%Sand%f.Check List
Tests