expression: fix issue that date_add and date_sub is incompatible with MySQL#9702
Merged
qw4990 merged 8 commits intopingcap:masterfrom Mar 29, 2019
Merged
expression: fix issue that date_add and date_sub is incompatible with MySQL#9702qw4990 merged 8 commits intopingcap:masterfrom
date_add and date_sub is incompatible with MySQL#9702qw4990 merged 8 commits intopingcap:masterfrom
Conversation
qw4990
added
type/compatibility
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #9702 +/- ##
===============================================
+ Coverage 77.4687% 77.547% +0.0783%
===============================================
Files 404 404
Lines 81682 81722 +40
===============================================
+ Hits 63278 63373 +95
+ Misses 13688 13648 -40
+ Partials 4716 4701 -15 |
alivxxx
reviewed
Mar 13, 2019
zz-jason
reviewed
Mar 13, 2019
lzmhhh123
reviewed
Mar 14, 2019
XuHuaiyu
changed the title
date_add and date_sub is incompatible with Mysqldate_add and date_sub is incompatible with Mysql
XuHuaiyu
changed the title
date_add and date_sub is incompatible with Mysqldate_add and date_sub is incompatible with MySQL
30 tasks
Contributor
Author
|
/run-all-tests |
1 similar comment
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/rebuild |
1 similar comment
Contributor
Author
|
/rebuild |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
/run-all-tests |
Contributor
Author
|
PTAL @lamxTyler |
alivxxx
reviewed
Mar 29, 2019
alivxxx
approved these changes
Mar 29, 2019
alivxxx
added
status/LGT2
Contributor
Author
|
/run-all-tests |
1 similar comment
Contributor
Author
|
/run-all-tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #9667
What is changed and how it works?
Check if it
datetimeif overflow whendate_addanddate_sub.Check List
Tests