Skip to content

expression: fix last_day function#9746

Merged
qw4990 merged 3 commits intopingcap:masterfrom
wjhuang2016:fix_last_day
Mar 15, 2019
Merged

expression: fix last_day function#9746
qw4990 merged 3 commits intopingcap:masterfrom
wjhuang2016:fix_last_day

Conversation

@wjhuang2016
Copy link
Copy Markdown
Member

What problem does this PR solve?

For #9731

What is changed and how it works?

Retun NULL as long as the month is 0.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

@xiekeyi98 xiekeyi98 added contribution This PR is from a community contributor. component/expression labels Mar 15, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 15, 2019

Codecov Report

Merging #9746 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##            master      #9746        +/-   ##
===============================================
- Coverage   67.234%   67.2239%   -0.0101%     
===============================================
  Files          380        380                
  Lines        79787      79787                
===============================================
- Hits         53644      53636         -8     
- Misses       21357      21365         +8     
  Partials      4786       4786

@lysu
Copy link
Copy Markdown
Contributor

lysu commented Mar 15, 2019

/run-all-tests

Copy link
Copy Markdown
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu requested a review from qw4990 March 15, 2019 06:20
@lysu lysu added status/LGT1 Indicates that a PR has LGTM 1. status/all tests passed labels Mar 15, 2019
Copy link
Copy Markdown
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 15, 2019
@qw4990
Copy link
Copy Markdown
Contributor

qw4990 commented Mar 15, 2019

@wjhuang2016 thanks for your contribution.
Could you please cherry-pick this PR into branch release 2.1 after it's merged.

@wjhuang2016
Copy link
Copy Markdown
Member Author

@wjhuang2016 thanks for your contribution.
Could you please cherry-pick this PR into branch release 2.1 after it's merged.

Please tell me how to do it, I'm not familiar with git.

@qw4990
Copy link
Copy Markdown
Contributor

qw4990 commented Mar 15, 2019

@wjhuang2016 thanks for your contribution.
Could you please cherry-pick this PR into branch release 2.1 after it's merged.

Please tell me how to do it, I'm not familiar with git.

Fetch branch release-2.1 to your local and then cherry-pick this PR into branch release-2.1 locally, then submit a new PR into TiDB release-2.1 😺

@qw4990 qw4990 merged commit 9187e3d into pingcap:master Mar 15, 2019
@wjhuang2016 wjhuang2016 deleted the fix_last_day branch November 17, 2022 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants