*: add_date can return mysql.Time#9830
Merged
tiancaiamao merged 13 commits intopingcap:masterfrom May 14, 2019
Merged
Conversation
Member
Author
|
The overflow checking is not finished. And i think the previous add_date will cause overflow too... |
winoros
commented
Mar 21, 2019
| "github.com/pingcap/tidb/util/testleak" | ||
| ) | ||
|
|
||
| func TestT(t *testing.T) { |
Codecov Report
@@ Coverage Diff @@
## master #9830 +/- ##
================================================
- Coverage 77.1152% 77.0556% -0.0597%
================================================
Files 412 412
Lines 86337 86457 +120
================================================
+ Hits 66579 66620 +41
- Misses 14672 14730 +58
- Partials 5086 5107 +21 |
tiancaiamao
reviewed
Mar 25, 2019
| return ZeroDuration, err | ||
| } | ||
| // MONTH must exceed the limit of mysql's duration. So just return overflow error. | ||
| return ZeroDuration, ErrDatetimeFunctionOverflow.GenWithStackByArgs("time") |
Contributor
There was a problem hiding this comment.
So why not ignore line 1902~1905 ?
Member
Author
There was a problem hiding this comment.
Oh, my concern is that though it must exceed the limit, should we raise the overflow error when the content cannot be formatted in fact?
Member
There was a problem hiding this comment.
is it controlled by a certain sql mode?
tiancaiamao
reviewed
Mar 25, 2019
Member
|
@winoros Please update this pr branch with the latest master |
qw4990
reviewed
May 6, 2019
qw4990
reviewed
May 7, 2019
qw4990
reviewed
May 7, 2019
Member
Author
|
Wait for #10329 merged first. |
30 tasks
Member
Author
|
/run-all-tests |
Contributor
|
LGTM |
tiancaiamao
added
status/all tests passed
status/LGT1
qw4990
added
status/LGT2
tiancaiamao
approved these changes
May 14, 2019
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Jun 5, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
to #9813
What is changed and how it works?
Implement things according to MySQL source code.
Check List
Tests
Side effects
Related changes