Skip to content

types: fix time_format is not compatible with MySQL.#9841

Merged
zz-jason merged 3 commits intopingcap:masterfrom
lzmhhh123:dev/fix9774
Mar 25, 2019
Merged

types: fix time_format is not compatible with MySQL.#9841
zz-jason merged 3 commits intopingcap:masterfrom
lzmhhh123:dev/fix9774

Conversation

@lzmhhh123
Copy link
Copy Markdown
Contributor

What problem does this PR solve?

fix #9774

What is changed and how it works?

Just do time.hour modular for some formats.

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 21, 2019

Codecov Report

Merging #9841 into master will increase coverage by 0.0004%.
The diff coverage is 66.6666%.

@@               Coverage Diff                @@
##             master      #9841        +/-   ##
================================================
+ Coverage   67.3554%   67.3558%   +0.0004%     
================================================
  Files           383        383                
  Lines         80436      80437         +1     
================================================
+ Hits          54178      54179         +1     
- Misses        21414      21415         +1     
+ Partials       4844       4843         -1

Copy link
Copy Markdown
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 25, 2019
@alivxxx
Copy link
Copy Markdown
Contributor

alivxxx commented Mar 25, 2019

/run-all-tests

@zhouqiang-cl
Copy link
Copy Markdown
Contributor

/rebuild

@zhouqiang-cl
Copy link
Copy Markdown
Contributor

/run-all-tests

@zz-jason
Copy link
Copy Markdown
Member

/run-unit-test

@zz-jason zz-jason merged commit 99defc0 into pingcap:master Mar 25, 2019
qw4990 pushed a commit to qw4990/tidb that referenced this pull request May 15, 2019
@lzmhhh123 lzmhhh123 deleted the dev/fix9774 branch July 24, 2019 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/expression status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TIME_FORMAT is not compatible with MySQL

5 participants