types: fix incorrect time fraction parsing method#9933
Merged
zz-jason merged 9 commits intopingcap:masterfrom Apr 1, 2019
Merged
types: fix incorrect time fraction parsing method#9933zz-jason merged 9 commits intopingcap:masterfrom
zz-jason merged 9 commits intopingcap:masterfrom
Conversation
Contributor
Author
|
/run-all-tests |
30 tasks
Contributor
|
/rebuild |
Contributor
|
/run-all-tests |
zz-jason
reviewed
Apr 1, 2019
Contributor
|
Any reference mysql doc? |
winkyao
reviewed
Apr 1, 2019
Member
|
/run-all-tests |
zz-jason
changed the title
Codecov Report
@@ Coverage Diff @@
## master #9933 +/- ##
================================================
+ Coverage 77.4719% 77.7943% +0.3224%
================================================
Files 403 403
Lines 81809 82479 +670
================================================
+ Hits 63379 64164 +785
+ Misses 13711 13631 -80
+ Partials 4719 4684 -35 |
Contributor
Author
|
@winkyao I search the mysql's document, can't find the detail about the format of date time string. I just execute in mysql to check. |
Member
|
@WangXiangUSTC Please cherry pick this PR to release 2.1 |
This was referenced Feb 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix issue #9734
tidb don't support date time format like "2019.01.01"
What is changed and how it works?
some minor update, and add unit test
Check List
Tests
Related changes