expression: fix issue that function dayname is incompatible with Mysql when doing arithmetic#9975
Merged
zz-jason merged 4 commits intopingcap:masterfrom Apr 2, 2019
Merged
Conversation
qw4990
added
type/compatibility
type/bugfix
alivxxx
reviewed
Apr 1, 2019
30 tasks
lzmhhh123
approved these changes
Apr 2, 2019
Codecov Report
@@ Coverage Diff @@
## master #9975 +/- ##
================================================
- Coverage 77.5219% 77.5157% -0.0062%
================================================
Files 403 403
Lines 81853 81844 -9
================================================
- Hits 63454 63442 -12
- Misses 13687 13691 +4
+ Partials 4712 4711 -1 |
zz-jason
reviewed
Apr 2, 2019
qw4990
added a commit
to qw4990/tidb
that referenced
this pull request
Jun 6, 2019
…sql when doing arithmetic (pingcap#9975)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #9713
When doing arithmetic using results of function
DayNamein MySQL, there is a special cast process that "Monday" should be cast to 0, "Tuesday" should be cast to 1 and so on.Now TiDB doesn't have this special cast process.
What is changed and how it works?
When building cast function, check if it is
DayName, and if it is, use its own special cast function.Check List
Tests