-
Notifications
You must be signed in to change notification settings - Fork 303
master(dm): support extra SHOW FULL TABLES columns from PolarDB-X #12481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
51906e6
refactor(conn): replace dbutil.GetTables with conn.GetTables for cons…
GMHDBJD 02b3e49
dm: refine PolarDB-X SHOW FULL TABLES compatibility
GMHDBJD 6155c52
dm,sync-diff: cover extra SHOW FULL TABLES columns
GMHDBJD 9a6b0a4
Merge remote-tracking branch 'upstream/master' into tiflow2/pr-12481-…
GMHDBJD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| // Copyright 2026 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package conn | ||
|
|
||
| import ( | ||
| "context" | ||
| "database/sql" | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/pingcap/errors" | ||
| "github.com/pingcap/tidb/pkg/util/dbutil" | ||
| ) | ||
|
|
||
| // GetTables returns names of all non-view tables in the specified schema. | ||
| // It is compatible with upstreams like PolarDB-X, whose SHOW FULL TABLES | ||
| // may return extra columns after the standard table name and table type. | ||
| func GetTables(ctx context.Context, db dbutil.QueryExecutor, schemaName string) ([]string, error) { | ||
|
OliverS929 marked this conversation as resolved.
|
||
| query := fmt.Sprintf("SHOW FULL TABLES IN `%s` WHERE Table_Type != 'VIEW';", escapeName(schemaName)) | ||
| return queryTables(ctx, db, query) | ||
| } | ||
|
|
||
| func queryTables(ctx context.Context, db dbutil.QueryExecutor, query string) ([]string, error) { | ||
| rows, err := db.QueryContext(ctx, query) | ||
| if err != nil { | ||
| return nil, errors.Trace(err) | ||
| } | ||
| defer rows.Close() | ||
|
|
||
| columns, err := rows.Columns() | ||
| if err != nil { | ||
| return nil, errors.Trace(err) | ||
| } | ||
| if len(columns) < 2 { | ||
| return nil, errors.Errorf("unexpected SHOW FULL TABLES result column count %d, expected at least 2", len(columns)) | ||
| } | ||
|
|
||
| tables := make([]string, 0, 8) | ||
| for rows.Next() { | ||
| var table, tableType sql.NullString | ||
| values := make([]any, len(columns)) | ||
| values[0] = &table | ||
| values[1] = &tableType | ||
| for i := 2; i < len(values); i++ { | ||
| values[i] = new(sql.RawBytes) | ||
| } | ||
|
|
||
| if err := rows.Scan(values...); err != nil { | ||
| return nil, errors.Trace(err) | ||
| } | ||
| if !table.Valid || !tableType.Valid { | ||
| continue | ||
| } | ||
|
|
||
| tables = append(tables, table.String) | ||
| } | ||
|
|
||
| return tables, errors.Trace(rows.Err()) | ||
| } | ||
|
|
||
| func escapeName(name string) string { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not related to this PR, but I found that there are three places in TiDB with this same (unexported) function 😂 |
||
| return strings.ReplaceAll(name, "`", "``") | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add one 4-column regression for
OpenAPIViewSuite.TestSourceAPIand one for the online-DDL checker path too? Right now the new coverage is mostly helper-level.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6155c52