Skip to content

API: Add iso datetimes to datalake response#105

Merged
Huzaifa-MS merged 1 commit intomasterfrom
add-iso-format-to-response
Apr 6, 2026
Merged

API: Add iso datetimes to datalake response#105
Huzaifa-MS merged 1 commit intomasterfrom
add-iso-format-to-response

Conversation

@Huzaifa-MS
Copy link
Copy Markdown
Contributor

-Make precision to ms and add Z
-Ading pytest -n auto plugin
-Better devshell name
-Fix Tests to run on new python.

@Huzaifa-MS Huzaifa-MS force-pushed the add-iso-format-to-response branch 2 times, most recently from 6a6c073 to 58ee3d7 Compare February 26, 2026 20:45
@Huzaifa-MS Huzaifa-MS changed the title Add iso to datalake response API: Add iso datetimes to datalake response Feb 26, 2026
@Huzaifa-MS Huzaifa-MS force-pushed the add-iso-format-to-response branch 12 times, most recently from 6287d83 to 9b29bab Compare February 27, 2026 17:06
@Huzaifa-MS Huzaifa-MS force-pushed the add-iso-format-to-response branch 13 times, most recently from b64ab49 to 53da153 Compare March 10, 2026 15:31
@Huzaifa-MS Huzaifa-MS force-pushed the add-iso-format-to-response branch 5 times, most recently from 4f8f3ca to d305e8a Compare March 16, 2026 12:40
@Huzaifa-MS Huzaifa-MS force-pushed the add-iso-format-to-response branch 19 times, most recently from 9115b20 to 5b1d8dd Compare April 1, 2026 20:21
huzaifams-svg

This comment was marked as off-topic.

@Huzaifa-MS
Copy link
Copy Markdown
Contributor Author

Huzaifa-MS commented Apr 1, 2026

Went through and reviewed code.
Passing local docker and github CI/CD

Went through Claude Code AI review and extended with this checklist

  • Use specific exceptions over generic ones
  • Remove comments unless direly essential
  • Put new tests / code in order of development
  • Don't add testing dependencies unless truly needed for project or local dev
  • Follow codebase conventions unless truly better. Not a huge check
  • Do not add local files to git i.e AI config files, editor config files, etc
  • Make logging statements concise, shorter without losing info

@Huzaifa-MS Huzaifa-MS force-pushed the add-iso-format-to-response branch from 5b1d8dd to 31f5104 Compare April 1, 2026 21:14
-Fix mistake made in tests of bad dict testing.
-Fixing epoc to UTC conversion. Handled None case.
-Change naming from UTC to iso
-Make precision to ms and add Z
-Ading pytest -n auto plugin
-Better devshell name
-Fix Tests to run on new python.
@Huzaifa-MS Huzaifa-MS force-pushed the add-iso-format-to-response branch from 31f5104 to 81f9295 Compare April 1, 2026 21:24
@Huzaifa-MS Huzaifa-MS merged commit 52eb2f4 into master Apr 6, 2026
0 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants