Skip to content

Tech Debt: Upgrading boto to boto3 for api & ingester#106

Merged
Huzaifa-MS merged 2 commits intomasterfrom
boto3-testing-upgrades
Apr 6, 2026
Merged

Tech Debt: Upgrading boto to boto3 for api & ingester#106
Huzaifa-MS merged 2 commits intomasterfrom
boto3-testing-upgrades

Conversation

@Huzaifa-MS
Copy link
Copy Markdown
Contributor

@Huzaifa-MS Huzaifa-MS commented Apr 1, 2026

Summary

Upgrades boto2 to boto3 for ingester and API components, and moto to v5 for testing.

Changes

  • Ingester migration: Update queue.py, reporter.py, storage.py to use boto3
  • Test improvements: Simplify AWS fixtures using context managers (39 lines → 9)
  • Moto v5: Upgrade from moto<3 to moto>=5,<6
  • Test infrastructure: Add make testp for parallel test execution
  • Version pinning: Pin boto3==1.35.41 and botocore==1.35.64 to fix tox issues
  • CI updates: Modernize GitHub Actions workflow

Copy link
Copy Markdown
Contributor Author

@Huzaifa-MS Huzaifa-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through and reviewed code.
Passing local docker and github CI/CD

Went through Claude Code AI review and extended with this checklist

  • Use specific exceptions over generic ones
  • Remove comments unless direly essential
  • Put new tests / code in order of development
  • Don't add testing dependencies unless truly needed for project or local dev
  • Follow codebase conventions unless truly better. Not a huge check
  • Do not add local files to git i.e AI config files, editor config files, etc
  • Make logging statements concise, shorter without losing info

-Fix mistake made in tests of bad dict testing.
-Fixing epoc to UTC conversion. Handled None case.
-Change naming from UTC to iso
-Make precision to ms and add Z
-Ading pytest -n auto plugin
-Better devshell name
-Fix Tests to run on new python.
@Huzaifa-MS Huzaifa-MS force-pushed the boto3-testing-upgrades branch from e81ce36 to 5e37e75 Compare April 1, 2026 21:24
@Huzaifa-MS Huzaifa-MS merged commit 43af5f9 into master Apr 6, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant