Tech Debt: Upgrading boto to boto3 for api & ingester#106
Merged
Huzaifa-MS merged 2 commits intomasterfrom Apr 6, 2026
Merged
Conversation
Huzaifa-MS
commented
Apr 1, 2026
Contributor
Author
Huzaifa-MS
left a comment
There was a problem hiding this comment.
Went through and reviewed code.
Passing local docker and github CI/CD
Went through Claude Code AI review and extended with this checklist
- Use specific exceptions over generic ones
- Remove comments unless direly essential
- Put new tests / code in order of development
- Don't add testing dependencies unless truly needed for project or local dev
- Follow codebase conventions unless truly better. Not a huge check
- Do not add local files to git i.e AI config files, editor config files, etc
- Make logging statements concise, shorter without losing info
-Fix mistake made in tests of bad dict testing. -Fixing epoc to UTC conversion. Handled None case. -Change naming from UTC to iso -Make precision to ms and add Z -Ading pytest -n auto plugin -Better devshell name -Fix Tests to run on new python.
…newer moto needed by client.
e81ce36 to
5e37e75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades boto2 to boto3 for ingester and API components, and moto to v5 for testing.
Changes
make testpfor parallel test execution