Use extended expression context for Control Panel actions#4341
Open
erral wants to merge 2 commits into
Open
Conversation
|
@erral thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
erral
force-pushed
the
erral-issue3288
branch
2 times, most recently
from
0eec8ba to
0820160
Compare
Member
Author
|
@jenkins-plone-org please run jobs |
gforcada
reviewed
Jun 11, 2026
gforcada
left a comment
gforcada
left a comment
Member
There was a problem hiding this comment.
LGTM without being an expert on this area of the code 😄
Member
Author
|
@jenkins-plone-org please run jobs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a more flexible expression context for Control Panel actions.
By using
get_current_context(), we can now use TALES expressions that depend on the current context (e.g., checking if a specific behavior is enabled on the current folder or document) when deciding whether to show a configlet in the control panel.Changes:
get_current_context()toProducts.CMFPlone.utilsto reliably find the current content object from the request.PloneControlPanel.enumConfigletsto use the current context for expression evaluation.get_current_context().PloneControlPanel.py.Fixes #3288