refactor(internals): Rev3 type narrowing for onMount hooks#3311
Open
dmaskasky wants to merge 1 commit intopmndrs:breaking/building-blocks-in-paramsfrom
Open
refactor(internals): Rev3 type narrowing for onMount hooks#3311dmaskasky wants to merge 1 commit intopmndrs:breaking/building-blocks-in-paramsfrom
dmaskasky wants to merge 1 commit intopmndrs:breaking/building-blocks-in-paramsfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/BC7QK34DW |
See documentations for usage instructions.
Made-with: Cursor
dmaskasky
force-pushed
the
internals/bb-rev3-type-guards
branch
from
68ceb04 to
493bc50
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type-only / helper improvements for Rev3 building blocks.
hasOnInitis not in this PR.BUILDING_BLOCK_ensureAtomStatestill callsatomOnInit?.(buildingBlocks, store, atom)on every new atom state (same as the upstream base).Changes
import typeforAtom/WritableAtom; addExtractAtomArgs/ExtractAtomResultfrom./typeUtils.ts.WritableAtomWithOnMountwithWithOnMountand useWritableAtom<…> & WithOnMount<…>onAtomOnMount.ActuallyWritableAtomand narrowisActuallyWritableAtomviatypeof write === 'function'.hasOnMountusingExtractAtomArgs/ExtractAtomResult.hasInitialValue/isAtomStateInitializedtweaks.