Skip to content

refactor(react): avoid eslint exception#1176

Merged
dai-shi merged 3 commits intomainfrom
fix/avoid-eslint-exception
Nov 3, 2025
Merged

refactor(react): avoid eslint exception#1176
dai-shi merged 3 commits intomainfrom
fix/avoid-eslint-exception

Conversation

@dai-shi
Copy link
Copy Markdown
Member

@dai-shi dai-shi commented Nov 3, 2025

It passes all the tests, but I'm not very confident if tests are comprehensive.

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
valtio Ready Ready Preview Comment Nov 3, 2025 1:39am

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci Bot commented Nov 3, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Nov 3, 2025

Size Change: +16 B (+0.11%)

Total Size: 14.7 kB

Filename Size Change
./dist/esm/react.mjs 701 B +7 B (+1.01%)
./dist/react.js 695 B +9 B (+1.31%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 63 B
./dist/esm/react/utils.mjs 257 B
./dist/esm/utils.mjs 68 B
./dist/esm/vanilla.mjs 2.34 kB
./dist/esm/vanilla/utils.mjs 3.69 kB
./dist/index.js 243 B
./dist/react/utils.js 278 B
./dist/utils.js 248 B
./dist/vanilla.js 2.38 kB
./dist/vanilla/utils.js 3.73 kB

compressed-size-action

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented Nov 3, 2025

More templates

npm i https://pkg.pr.new/valtio@1176

commit: 16b30de

@dai-shi dai-shi merged commit 88352d0 into main Nov 3, 2025
33 checks passed
@dai-shi dai-shi deleted the fix/avoid-eslint-exception branch November 3, 2025 01:45
@zardoy
Copy link
Copy Markdown

zardoy commented Feb 19, 2026

im pretty sure after this commit I've started noticing in an edge-case (when there is a lot of updates), but an easy-to-reproduce bug leading to desync with just captured snapshot data on init render and actual proxy data, downgrading from 2.2.0 to 2.1.8 seems do the thing (but im not confident either)

I'd like to elaborate, but for me it is extremely hard to debug Valtio, can't get the sense of where to put breakpoints at what time

@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented Feb 19, 2026

I feel like I should revert this. It would be really great if we have a failing test.

@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented Feb 19, 2026

I'd like to elaborate, but for me it is extremely hard to debug Valtio

You don't need to debug, but could you provide a minimal reproduction so that we can create a test case. If you could create a test case, it's super nice.

@zardoy
Copy link
Copy Markdown

zardoy commented Feb 22, 2026

I'm sincerely sorry but I think it's currently out of my scope. The code is closed-source, and the issue got fixed by locking the dep.

The case itself has a very long and complex reproduction path involving specific actions at specific timings, but no worries if the issue was really introduced by this changed I think someone else would report it since this lib is very popular nowadays:)

@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented Feb 23, 2026

No worries. I'll see if I can try.

dai-shi added a commit that referenced this pull request Mar 3, 2026
@dai-shi dai-shi mentioned this pull request Mar 3, 2026
1 task
@dai-shi
Copy link
Copy Markdown
Member Author

dai-shi commented Mar 3, 2026

#1206

dai-shi added a commit that referenced this pull request Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants