Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Size Change: +16 B (+0.11%) Total Size: 14.7 kB
ℹ️ View Unchanged
|
commit: |
|
im pretty sure after this commit I've started noticing in an edge-case (when there is a lot of updates), but an easy-to-reproduce bug leading to desync with just captured snapshot data on init render and actual proxy data, downgrading from 2.2.0 to 2.1.8 seems do the thing (but im not confident either) I'd like to elaborate, but for me it is extremely hard to debug Valtio, can't get the sense of where to put breakpoints at what time |
|
I feel like I should revert this. It would be really great if we have a failing test. |
You don't need to debug, but could you provide a minimal reproduction so that we can create a test case. If you could create a test case, it's super nice. |
|
I'm sincerely sorry but I think it's currently out of my scope. The code is closed-source, and the issue got fixed by locking the dep. The case itself has a very long and complex reproduction path involving specific actions at specific timings, but no worries if the issue was really introduced by this changed I think someone else would report it since this lib is very popular nowadays:) |
|
No worries. I'll see if I can try. |
It passes all the tests, but I'm not very confident if tests are comprehensive.