fix WASI & Android build, add to CI and add Combine package trait#406
Open
diederich wants to merge 10 commits intopointfreeco:mainfrom
Open
fix WASI & Android build, add to CI and add Combine package trait#406diederich wants to merge 10 commits intopointfreeco:mainfrom
Combine package trait#406diederich wants to merge 10 commits intopointfreeco:mainfrom
Conversation
Member
|
@diederich Thanks for taking the time to PR! And sorry for the delay, holiday travel and all 😄 Just a few things:
|
Author
No worries at all. I can relate! :-)
Love it. Will take a look! 🙏
Gotcha, makes sense.
Yeah, agreed. Will take a look and keep us posted. |
|
Hi! Any updates on this? We may be able to help if you can give us directions (like fixing the CI support) :) |
diederich
force-pushed
the
bugfix/wasm-build
branch
from
bb3a0a1 to
a437d05
Compare
``` error: dynamic libraries are unsupported for target 'wasm32-unknown-wasip1' [3/15] Linking libIssueReportingTestSupport.wasm ```
Author
Author
|
@stephencelis NotificationCenter was the only required fix now. OpenCombine did the trick. As mentioned in the PR description, I picked the swift-nio workflow. While that builds against main (and haven't seen a flag to change), it should be relatively maintenance free. Let me know it that's OK or if you want something more custom/configurable. (Oh, and sorry this took so long. Was in a bit of a frenzy putting all the things together 😅 ) |
so it can be disabled on non-supported platforms, e.g. currently Android
Author
|
OK - more incoming 😅
|
diederich
changed the title
Combine package trait
we're importing the Shim now, which should be available in case `#if Combine` resolved to true. It's kind of sad we're leaking
…lerPlugin` not being picked up
I'm not clear why we were seeing:
```/__w/swift-dependencies/swift-dependencies/Tests/DependenciesMacrosPluginTests/DependencyClientMacroTests.swift:1:8: error: missing required module 'SwiftCompilerPlugin'
1 | import DependenciesMacrosPlugin
| `- error: missing required module 'SwiftCompilerPlugin'
2 | import MacroTesting
3 | import XCTest
[942/955] Compiling DependenciesMacrosPluginTests BaseTestCase.swift
/__w/swift-dependencies/swift-dependencies/Tests/DependenciesMacrosPluginTests/DependencyClientMacroTests.swift:1:8: error: missing required module 'SwiftCompilerPlugin'
1 | import DependenciesMacrosPlugin
| `- error: missing required module 'SwiftCompilerPlugin'
2 | import MacroTesting
3 | import XCTest
[943/955] Compiling DependenciesMacrosPluginTests DependencyEndpointMacroTests.swift
/__w/swift-dependencies/swift-dependencies/Tests/DependenciesMacrosPluginTests/DependencyClientMacroTests.swift:1:8: error: missing required module 'SwiftCompilerPlugin'
1 | import DependenciesMacrosPlugin
| `- error: missing required module 'SwiftCompilerPlugin'
2 | import MacroTesting
3 | import XCTest
```
on https://github.com/untitled-in-brackets/swift-dependencies/actions/runs/22952803121/job/66621506036
but hoping being explicit fixes it (and we import, so should be fine?)
Author
|
Looks like we're green with Android, WASI & the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trying to build
swift-dependenciesagainst the WASM SDK failed because of:NotificationCentertypeExcluding the
NotificationCenterdependency on WASI fixes it.This now also borrows swift-nio's WASM build (saw that recently in swift-distributed-tracing), but given building w/o arguments tries to build
libIssueReporting.wasmas a dynamic library (how is that the default target 😅 ) and complains, we're passing--target Dependenciesand--target DependenciesMacrosalong.