bug: is_inherited still in GraphQL schema for attribute types, but resolver missing in 1.9.x

[polmichel]

Component

No response

Infrahub version

1.9.x

Current Behavior

The GraphQL schema (introspection) on Infrahub 1.9.x advertises an is_inherited: Boolean field on AttributeInterface and every concrete attribute type (TextAttribute, Dropdown, NumberAttribute, MacAddress, IPHost, IPNetwork, CheckboxAttribute, String, etc.). At runtime, selecting that field fails with '<AttributeKind>' object has no attribute 'is_inherited'.

Any consumer that generates a typed client from the schema and selects all schema fields hits this on the first non-trivial attribute query (like I do in https://github.com/cyberwitchery/infrahub.rs/). This looks like incomplete cleanup from the deprecation discussed in opsmill#3104: the resolver was removed but the schema definition wasn't.

Expected Behavior

Expected from me, either:

• the runtime resolves is_inherited correctly, or
• the field is removed from the schema definition so introspection-driven clients don't generate code that selects it.

Steps to Reproduce

Minimal query against a fresh 1.9.3 instance (default seeding, anonymous access enabled):

{
  CoreAccount {
    edges {
      node {
        name {
          is_inherited
        }
      }
    }
  }
}

Response:

{
  "data": null,
  "errors": [
    {
      "message": "'String' object has no attribute 'is_inherited'",
      "locations": [{ "line": 5, "column": 11 }],
      "path": ["CoreAccount"]
    }
  ]
}

Same failure for Dropdown (e.g. account_type { is_inherited } on CoreAccount) and every other concrete attribute type. Schema introspection still emits 11 occurrences of is_inherited (one on the interface plus 10 implementers).

Additional Information

Tested on 1.9.0 and 1.9.3

[polmichel]

/bug-analyze

[infrahub-bug-pipeline]

✅ Bug analyst agent completed successfully!

[infrahub-bug-pipeline]

Root cause analysis for #12

Issue: bug: is_inherited still in GraphQL schema for attribute types, but resolver missing in 1.9.x
Based on: db2df018791ce702ff835c582dc4d58629507e19
Bug clarity: CLEAR
Code identification: RESOLVED

Root cause

is_inherited = Field(Boolean) remains declared on AttributeInterface in the GraphQL type definitions, but the corresponding is_inherited instance attribute was removed from the backend BaseAttribute class, so to_graphql() raises AttributeError when any client selects that field.

Affected files

• backend/infrahub/graphql/types/attribute.py — line 64: is_inherited = Field(Boolean) on AttributeInterface is the leftover schema declaration with no backing implementation
• backend/infrahub/core/attribute.py — line 527 (to_graphql), line 593: the generic getattr(self, field_name) call fails when is_inherited is in the requested fields, producing AttributeError: 'String' object has no attribute 'is_inherited' (where 'String' is the Python class at line 712)

Explanation

AttributeInterface (a graphene interface) declares is_inherited = Field(Boolean) at line 64 of attribute.py. Every concrete attribute type implements this interface (TextAttributeType, DropdownType, IPHostType, etc.), so the field appears on all of them in the published schema.

When the GraphQL engine resolves name { is_inherited }, it calls BaseAttribute.to_graphql() on the attribute object. Inside to_graphql() (line 548–608), for any field_name that is not a special-case (updated_at, updated_by, __typename, permissions, source, owner), the method falls through to the generic branch:

field = getattr(self, field_name)   # line 593

BaseAttribute (and all its subclasses) has no is_inherited instance attribute. FlagPropertyMixin._flag_properties (which drives which flags are set on __init__) only contains ["is_protected"] — FlagProperty enum has a single member IS_PROTECTED. There is no is_inherited in FlagProperty, MetadataOptions, or anywhere in BaseAttribute.__init__. The result is an unhandled AttributeError.

The error message 'String' object has no attribute 'is_inherited' comes from class String(BaseAttribute) at line 712 — the Python backend type for text attributes — when the name field (a String attribute) is queried.

The test helper in backend/tests/unit/test_types.py:36 already hard-codes "is_inherited" into its excluded_fields list, which is a silent workaround for the broken state rather than a deliberate design choice.

Fix strategy

Approach: Remove is_inherited = Field(Boolean) from AttributeInterface (line 64 of backend/infrahub/graphql/types/attribute.py). This is the canonical source for the GraphQL schema; removing it there eliminates the field from the interface and from all concrete attribute types at once. No resolver or backend data is needed because the property no longer exists in the runtime model.

Scope: Single-line deletion in backend/infrahub/graphql/types/attribute.py. The generated schema/schema.graphql will reflect the change on the next schema export (requires a running instance; do not hand-edit the generated file). No database migration is required.

Do NOT:

• Re-add is_inherited to FlagProperty or BaseAttribute.__init__ — the field was intentionally removed from the runtime model.
• Edit schema/schema.graphql directly — it is a generated file and must not be manually modified.
• Change the excluded_fields list in test_types.py — that list is already correct and will remain correct after the fix (since is_inherited is simply gone from the schema).
• Add a resolve_is_inherited method to AttributeInterface returning None — that would keep a dead field in the public schema and still break introspection-driven clients that generate non-nullable usages.

Notes for downstream steps

• The fix is a one-line deletion. The test-writer should write a unit test asserting that AttributeInterface._meta.fields does not contain "is_inherited" after the removal.
• All 11 occurrences in schema/schema.graphql (interface + 10 implementors) will disappear automatically on the next schema export — no action needed there.
• The python_sdk/infrahub_sdk/node/attribute.py still has is_inherited on the SDK-side attribute class (line 84); that is a separate SDK concern and is out of scope for the backend fix.

AGENT_ANALYSIS_COMPLETE

Generated by Bug analyst agent for issue #12 · ● 321.4K · ◷

[polmichel]

/bug-tdd

[infrahub-bug-pipeline]

Pull request created: #13

Generated by Bug test-writer agent

[infrahub-bug-pipeline]

A draft PR with the failing test has been created on branch ai-bug-pipeline-12-is-inherited-graphql.

Test: backend/tests/unit/graphql/types/test_attribute.py::test_attribute_interface_does_not_expose_is_inherited

The test asserts "is_inherited" not in AttributeInterface._meta.fields. It currently fails with AssertionError because the orphaned is_inherited = Field(Boolean) declaration is still present on AttributeInterface at line 64 of backend/infrahub/graphql/types/attribute.py.

Generated by Bug test-writer agent for issue #12 · ● 340.4K · ◷

[infrahub-bug-pipeline]

✅ Bug test-writer agent completed successfully!

No action needed: PR #13 already exists from a prior /bug-tdd run (workflow 25423469397) and contains a valid failing test (backend/tests/unit/graphql/types/test_attribute.py::test_attribute_interface_does_not_expose_is_inherited) with AGENT_TEST_COMPLETE. This invocation is a duplicate trigger of the same issue comment; all work is already complete.

[infrahub-bug-pipeline]

Fix implemented in PR #13.

Root cause: is_inherited = Field(Boolean) was left on AttributeInterface in backend/infrahub/graphql/types/attribute.py after the runtime attribute was removed from BaseAttribute, causing AttributeError on any query selecting that field.

Fix: Single-line deletion of is_inherited = Field(Boolean) from AttributeInterface. The generated schema/schema.graphql (11 occurrences removed) and frontend/app/src/shared/api/graphql/generated/graphql-env.d.ts were regenerated. All 705 unit tests pass.

Generated by Bug fixer agent for issue #13 · ● 340.9K · ◷