Conversation
Create 2022_KumarScience_Xinjiang.janno
|
I was able to download the genotype data for this package from a platform in China to which the author had uploaded it. |
|
Oookay, so I've gone through some of the review points. Some quick remarks on them:
|
|
So the one task left to do is fixing the relationships in terms of Poseidon_IDs. I think we need to make do this with a short script and some lookup table to exchange Alternative and Poseidon_IDs. @ainashch do you think you can perhaps just download the Janno file from this PR, work on this and send the fixed one back to me so I can included it? |
|
@ainashch Are you available to have a look at this? Otherwise maybe @Kavlahkaff could take over. Please let us know, so that we can make a decision how to proceed with this package draft. |
|
It would be great if @Kavlahkaff could take over, please. There is really only one todo left, which is to fix the |
|
Some observations today:
So please add those as identical, even if we do not have a package for Zhang et al. 2021.
|
|
And could you please add the Zhang et al. 2021 paper (see https://www.poseidon-adna.org/paper-directory/ and search for Zhang Tarim) as a Minotaur recipe, @Kavlahkaff |
|
This all seems done. Ready for review. |
This is a take-over of #206 by @ainashch. A first review by @nevrome was:
Year_AuthorName_RelevantKeyword. I propose2022_Kumar_Xinjiang.n/a.Relation_Tocolumn works with theAlternative_IDs, not thePoseidon_IDs. Is there a reason why there are two sample naming schemes existing in parallel? Why did you opt for the alternative one for theRelation_Tocolumn? I think there are multiple possible solutions to this.Relation_Degree==first+Relation_Type==identicalto express that two samples are from the same individual. This is not necessary.Relation_Degreecan be set toidenticaldirectly.G218- just to make sure: This is a proper site name?Siteset toUnknown. I think it would be better to put it ton/a.Date_Typeshould be set tocontextualfor contextual ages.Date_Notethen does not need the redundant*Date contextual(what does the*mean?).Date_BC_AD_Mediancan be computed as the mean ofDate_BC_AD_StartandDate_BC_AD_Stopfor contextual ages.Publicationcolumn is typically used for a bibtex key in a complete package. In this .janno-only submission we can leave it like it is for now.