Add 2025_SkourtaniotiJia_SCaucasus#293
Conversation
|
Thank you for this submission! The validation currently fails with some encoding-related issue in https://github.com/poseidon-framework/community-archive/blob/master/checkFileEncoding.sh. Either the .janno file is not utf8-encoded, or it has windows line endings. |
|
@nevrome thank you so much for the quick review! Now I fixed the line endings! |
|
OK - this looks ready for review! But I think the paper is not out yet, right? The bibtex entry is still missing a doi. I assume we should wait with merging the package until everything is properly released. Could you review, @martynamolak? You have offered to do so in the past, so that's why I'm asking you directly. Feel free to decline the request if this comes at a busy time 👍! The review guide is available here. |
|
Hey, if noone else signed up for that yet, I can do it, but probably only early next week. If that is fine than count me in. |
|
That is excellent! Thank you very much, Martina! |
|
@nevrome thank you for arranging the review and @martynamolak thank you for reviewing it! I have updated the doi information so there should be no problem with merging the package when the review is done:) |
added month to the references
|
yml file:
bib file:
janno file:
|
|
Thanks for this thorough review, @martynamolak. As always excellent! And thanks for even editing the .bib file directly.
Beyond that:
Please address all 13 points in your revision, @xiaowenjia. I'm happy to help with any additional open questions. |
|
Thank you both very much! I will look into them! |
|
Hi @nevrome and @martynamolak, |
|
OK - I applied some more minor tweaks to the .janno file. Most notably, the |
PR Checklist for a new package submission
POSEIDON.ymlconforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>, e.g.2021_Zegarac_SoutheasternEurope,2021_SeguinOrlando_BellBeakeror2021_Kivisild_MedievalEstonia.Poseidon_IDof the form<Original Poseidon_ID>_<Initials of the main author>_<Year>. Re-analysed versions ofI1685(Lazaridis et al. 2016) should, for example, be assigned the IDsI1685_IL22(Lazaridis et al. 2022) andI1685_IL25(Lazaridis et al. 2025).POSEIDON.ymlfile with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion,title,description,contributor,packageVersion,lastModified(see here for their definition).jannofile (for a list of available fields look here and here for more detailed documentation about them)..bibfile with the necessary literature references for each sample in the.jannofile.POSEIDON.ymlfile and there are no additional, supplementary files in the submission that are not documented there..jannoand.bibfile are all named after the package title and only differ in the file extension.POSEIDON.ymlfile is1.0.0.poseidonVersionof the package in thePOSEIDON.ymlfile is set to the latest version of the Poseidon schema.POSEIDON.ymlfile contains the corresponding checksums for the fieldsgenoFile,snpFile,indFile,jannoFileandbibFile.CHANGELOGfile or one with a single entry for version1.0.0.Publicationcolumn in the.jannofile is filled and the respective.bibfile has complete entries for the listed mentioned keys..jannofile does not include any empty columns or columns only filled withn/a..jannofile adheres to the standard order as defined in the Poseidon schema here..jannoand the.ssffiles are not fully quoted, so they only use single- or double quotes ("...",'...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno.git lfs migrate import --no-rewrite path/to/file.bed(see here).