Skip to content

Add 2024_Higgins_LeMuraInfant#298

Merged
nevrome merged 2 commits intoposeidon-framework:masterfrom
Tlkhi:add_2024_Higgins_MuraUP
Sep 14, 2025
Merged

Add 2024_Higgins_LeMuraInfant#298
nevrome merged 2 commits intoposeidon-framework:masterfrom
Tlkhi:add_2024_Higgins_MuraUP

Conversation

@Tlkhi
Copy link
Copy Markdown
Contributor

@Tlkhi Tlkhi commented Sep 3, 2025

PR Checklist for a new package submission

  • The package does not exist already in the community archive, also not with a different name.
  • The package title in the POSEIDON.yml conforms to the general title structure suggested here: <Year>_<Last name of first author>_<Region, time period or special feature of the paper>, e.g. 2021_Zegarac_SoutheasternEurope, 2021_SeguinOrlando_BellBeaker or 2021_Kivisild_MedievalEstonia.
  • The package is stored in a directory that is named like the package title.

  • Samples that already have been published previously, and got re-analysed (e.g. re-sequenced) for the now packaged publication, have a modified Poseidon_ID of the form <Original Poseidon_ID>_<Initials of the main author>_<Year>. Re-analysed versions of I1685 (Lazaridis et al. 2016) should, for example, be assigned the IDs I1685_IL22 (Lazaridis et al. 2022) and I1685_IL25 (Lazaridis et al. 2025).

  • The package is complete and features the following elements:
    • Genotype data in binary PLINK format (not EIGENSTRAT format).
    • Genotype has been provided by the original authors of the publication describing the data.
    • A POSEIDON.yml file with not just the file-referencing fields, but also the following meta-information fields present and filled: poseidonVersion, title, description, contributor, packageVersion, lastModified (see here for their definition)
    • A reasonably filled .janno file (for a list of available fields look here and here for more detailed documentation about them).
    • A .bib file with the necessary literature references for each sample in the .janno file.
  • Every file in the submission is correctly referenced in the POSEIDON.yml file and there are no additional, supplementary files in the submission that are not documented there.
  • Genotype data, .janno and .bib file are all named after the package title and only differ in the file extension.
  • The package version in the POSEIDON.yml file is 1.0.0.
  • The poseidonVersion of the package in the POSEIDON.yml file is set to the latest version of the Poseidon schema.
  • The POSEIDON.yml file contains the corresponding checksums for the fields genoFile, snpFile, indFile, jannoFile and bibFile.
  • There is either no CHANGELOG file or one with a single entry for version 1.0.0.

  • The Publication column in the .janno file is filled and the respective .bib file has complete entries for the listed mentioned keys.
  • The .janno file does not include any empty columns or columns only filled with n/a.
  • The order of columns in the .janno file adheres to the standard order as defined in the Poseidon schema here.
  • The .janno and the .ssf files are not fully quoted, so they only use single- or double quotes ("...", '...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).

  • The package passes a validation with trident validate --fullGeno.

  • Large genotype data files are properly tracked with Git LFS and not directly pushed to the repository. For an instruction on how to set up Git LFS please look here. If you accidentally pushed the files the wrong way you can fix it with git lfs migrate import --no-rewrite path/to/file.bed (see here).

@smpeltola smpeltola self-assigned this Sep 8, 2025
Copy link
Copy Markdown
Contributor

@smpeltola smpeltola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This package looks very good, thank you again @Tlkhi ! Just a few minor comments:

  • The title could be a bit more descriptive, e.g. 2024_Higgins_LeMuraInfant
  • I could not find the Group_label in the publication. If this label is consistent with AADR or other one of the Poseidon Archives, then no problem, but otherwise I would suggest using the individual label as the primary group label.
  • Coordinates place the site offshore. Could you double-check them?

@Tlkhi
Copy link
Copy Markdown
Contributor Author

Tlkhi commented Sep 9, 2025

This package looks very good, thank you again @Tlkhi ! Just a few minor comments:

  • The title could be a bit more descriptive, e.g. 2024_Higgins_LeMuraInfant
  • I could not find the Group_label in the publication. If this label is consistent with AADR or other one of the Poseidon Archives, then no problem, but otherwise I would suggest using the individual label as the primary group label.
  • Coordinates place the site offshore. Could you double-check them?

Thank you for reviewing this and for your comments;

  1. Isn’t the title (MuraUP (Upper Paleolithic)) already clear?

  2. The sample is from Italy (Mura) and belongs to the Late Upper Paleolithic period

  3. Right - I’ll fix that

@Tlkhi Tlkhi changed the title Add 2024_Higgins_MuraUP Add 2024_Higgins_LeMuraInfant Sep 9, 2025
@Tlkhi Tlkhi requested a review from smpeltola September 9, 2025 22:32
@nevrome
Copy link
Copy Markdown
Member

nevrome commented Sep 14, 2025

This looks fine to me - thanks! Will merge now.

@nevrome nevrome merged commit 7d0a4a2 into poseidon-framework:master Sep 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants