Add_2025_Gretzinger_SlavicPeriod#303
Conversation
|
Thank you for preparing this package! At a first quick glance I see the following minor issues:
@Tlkhi thankfully agreed to provide a more thorough review 🙏 |
Corrected the name of Y_Haplogroup column
corrected jannoFileChkSum
changed names of genotype files
|
For the time being @ltcrod has offered to provide a (second) review. Thank you 👍 |
|
Thank you for submitting this package, and sorry for my late review. Here are my comments: – janno file: The following columns should be added and filled in correctly: For It would also be better to replace the archaeological dates of carbon-dated samples with their calibrated C14 dates. I see some identical samples mentioned in the supplementary table, A – ssf file: Links/values for fastq_aspera, fastq_bytes, fastq_md5, fastq_ftp, read_count, and submitted_ftp are missing. The rest of the files look good to me. Thankfully, @ltcrod will also provide a second review |
added relevant information
updated sequencingSourceFileChkSum
edited sequencingSourceFileChkSum
sequencingSourceFileChkSum
Updated dating and relatedness information
jannoFileChkSum
Added n/a to Note
Updated Brücken IDs
Updated checksums
|
Thank you for your comments!
|
|
Thanks for the review, @Tlkhi, and thanks for addressing it promptly, @denisazlamalova. It looks OK for me now. Will merge. |
PR Checklist for a new package submission
POSEIDON.ymlconforms to the general title structure suggested here:<Year>_<Last name of first author>_<Region, time period or special feature of the paper>, e.g.2021_Zegarac_SoutheasternEurope,2021_SeguinOrlando_BellBeakeror2021_Kivisild_MedievalEstonia.Poseidon_IDof the form<Original Poseidon_ID>_<Initials of the main author>_<Year>. Re-analysed versions ofI1685(Lazaridis et al. 2016) should, for example, be assigned the IDsI1685_IL22(Lazaridis et al. 2022) andI1685_IL25(Lazaridis et al. 2025).POSEIDON.ymlfile with not just the file-referencing fields, but also the following meta-information fields present and filled:poseidonVersion,title,description,contributor,packageVersion,lastModified(see here for their definition).jannofile (for a list of available fields look here and here for more detailed documentation about them)..bibfile with the necessary literature references for each sample in the.jannofile.POSEIDON.ymlfile and there are no additional, supplementary files in the submission that are not documented there..jannoand.bibfile are all named after the package title and only differ in the file extension.POSEIDON.ymlfile is1.0.0.poseidonVersionof the package in thePOSEIDON.ymlfile is set to the latest version of the Poseidon schema.POSEIDON.ymlfile contains the corresponding checksums for the fieldsgenoFile,snpFile,indFile,jannoFileandbibFile.CHANGELOGfile or one with a single entry for version1.0.0.Publicationcolumn in the.jannofile is filled and the respective.bibfile has complete entries for the listed mentioned keys..jannofile does not include any empty columns or columns only filled withn/a..jannofile adheres to the standard order as defined in the Poseidon schema here..jannoand the.ssffiles are not fully quoted, so they only use single- or double quotes ("...",'...') to enclose text fields where it is strictly necessary (i.e. their entry includes a TAB).trident validate --fullGeno.git lfs migrate import --no-rewrite path/to/file.bed(see here).