Skip to content

2021_Delser_ShotgunGenomes#68

Merged
TCLamnidis merged 13 commits intomainfrom
2021_Delser_ShotgunGenomes
Mar 23, 2026
Merged

2021_Delser_ShotgunGenomes#68
TCLamnidis merged 13 commits intomainfrom
2021_Delser_ShotgunGenomes

Conversation

@TCLamnidis
Copy link
Copy Markdown
Member

@TCLamnidis TCLamnidis commented Feb 10, 2026

Adds/Updates 2021_Delser_ShotgunGenomes

Linked to poseidon-framework/minotaur-recipes#143

If this PR adds a new package to the archive, please note:
New packages added to the minotaur archive are always published in version 1.0.0.
This means that any and all changes made to the package during the review process, should only bump the Minor or Patch version of the package.

PR checklist:

  • The package description has been updated to the title of the paper.
  • This package contains a BibTex file.
  • The month field in the BibTex file is formatted as a three letter code.
  • If this package already exists in the community archive:
    • The information from the community archive was used to fill-in empty janno fields (if applicable).
    • The commands used for the fill-in and any tool versions are kept track of in the README file.
    • The BibTex key used for the citation is identical to that in the corresponding package in the community archive.
    • The DOI in the BibTex file is identical to the one used in the corresponding package in the community archive.
  • If the janno information was collected manually:
    • Add any additional contributors to POSEIDON.yml
  • Any scripts/commands used to prepare the pacakge are kept track of in the README file.
  • Country information is also present in the Country_ISO column.
  • Any columns in the janno that are entirely missing or n/a should be removed from the janno.
  • If Y_Haplogroups were provided in the ISOGG format, the column should be renamed to Y_Haplogroups_ISOGG
  • Poseidon_IDs in the Relation_To column contain the _MNT suffix.

Once the Pull Request has passed the review process, ensure the package version is bumped once more before publishing with:

trident rectify -d <package_dir> --logText 'Bump version for release' --packageVersion Major --checksumAll

@TCLamnidis TCLamnidis changed the title Add: 2021_Delser_ShotgunGenomes 2021_Delser_ShotgunGenomes Feb 10, 2026
Copy link
Copy Markdown
Member

@nevrome nevrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe an Alternative_IDs_Context .janno column would help to contextualize the Alternative_IDs in anticipation of Poseidon v3.0.0.

I was also wondering if we should specify an Contamination_Nr_SNPs and the Y_Haplogroups_ISOGG column some time in the future.

@stschiff stschiff removed their request for review March 2, 2026 09:19
@TCLamnidis TCLamnidis merged commit 49ece69 into main Mar 23, 2026
1 check passed
@TCLamnidis TCLamnidis deleted the 2021_Delser_ShotgunGenomes branch March 23, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants